Comments (16)
Hi @FrankBrullo, the handlers are ready and the release pipeline is working again!
from britecharts-react.
Hi @miglesiasEB sorry for the radio silence but I got some issues to continue working on the PR.
Now I have sorted out everything and I have restarted.
Is there a way I can get an invite to join your slack channel so I can ask you a couple of questions I have?
@dupski Thank you for the offer I will definitely take it! :) I will send you a preliminary PR for you to review because I am not much familiar with most of the chart and probably I will not have time to check all of them once I am done with the TS definitions.
from britecharts-react.
Hi @FrankBrullo, thanks for opening this issue.
Yes, we don't have TS types. Several people talked about it in https://github.com/eventbrite/britecharts/issues/223, but never came out of it yet.
We are open to PRs though.
from britecharts-react.
Ok, I will do and let you know when the PR is ready.
Also, while I am looking at the Donut, I am not seeing implemented customMouseMove and more importantly customClick.
Any idea why?
How can I get the click event in React if they aren't defined as props?
Thanks.
from britecharts-react.
That would be awesome @FrankBrullo!! Thanks a lot for doing this!!
True, those handlers are not set, but they should. We would need to add them there as proptypes and they should be ready to use!
from britecharts-react.
@Golodhros That would be great!
Do you have an ETA on when it will be fixed?
I need to include those events in my Typescript types for the Pie Chart before sending the PR to you.
Thanks,
Frank
from britecharts-react.
I will try to go over it this weekend, but until we fix the release issue(hopefully next week) we won't be able to publish it.
from britecharts-react.
Let me know when you push your changes on Git so I can update my fork.
I hope to deliver the Typescript changes before your release so we will have everything in one shot.
from britecharts-react.
Handlers Added!
from britecharts-react.
+1 for TS support. Give me a shout if you need any assistance @FrankBrullo :)
from britecharts-react.
Same here regarding familiarity @FrankBrullo as I'm only just starting with this library but happy to take a look and give it a test :)
from britecharts-react.
Sounds good!
We have a channel in the official d3 slack. Join us there @FrankBrullo !
from britecharts-react.
Any motion on this?
from britecharts-react.
Not really, a lot of people offered to add the types but nobody actually did!
from britecharts-react.
I think It would be interesting to have this one, since some types can be reused. Anyway, we can start typing the props and the whole config before that gets merged. May I work on this ? :D
from britecharts-react.
Hi @ImADrafter!
I hope we could reuse the types between Britecharts and Britecharts-react, and use them to keep track of how complete are the Britechart React apis.
In my mind, the future should be a monorepo for britecharts, with @britecharts/core, @britecharts/react, @britecharts/types, @britecharts/angular and so on.
If you have time to work on this stuff, I would actually love to get some help on making britecharts/britecharts#868 work.
from britecharts-react.
Related Issues (20)
- Cant set tooltip title to empty string HOT 2
- Bar Chart Y-axis name value getting truncated to '...' HOT 14
- StackedArea chart doesn't render correctly HOT 2
- Add customMouseMove and customClick to Donut chart
- Importing withResponsiveness() helper HOT 7
- Update project's documentation HOT 5
- Update Node HOT 3
- Tooltip with StackedBar not being rendered HOT 10
- Parse error when when generating chart boilerplate via plop HOT 2
- Styling ticks to fix offset and overlap HOT 7
- highlightSliceById prop of Donut component is not working
- Chart does not render with Tooltip when data is progressively added HOT 4
- Feature Proposal HOT 7
- Support Locale in Bar Chart HOT 1
- Broken and unclear documentation HOT 10
- customClick method is not working HOT 3
- Move implementation into Hooks HOT 1
- Move into TypeScript HOT 1
- How to change the font-size for the x- and y-axes? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from britecharts-react.