`device.stop_livestream` does not generate an event as `livestream stopped` about eufy-security-ws

[bropat]

@fuatakgun Version 0.5.1 released

[fuatakgun]

Got it, thanks, i will check

[fuatakgun]

Logs from docker;

LivestreamNotRunningError  Livestream for device T8113N63205014E2 could not be stopped, because it is not running
details:
{
  name: 'LivestreamNotRunningError'
}
error stack:
• message_handler.ts:145 handle
    src/lib/device/message_handler.ts:145:31
• server.ts:46 device
    src/lib/server.ts:46:34
• server.ts:98 receiveMessage
    src/lib/server.ts:98:58
• server.ts:57 <anonymous>
    src/lib/server.ts:57:53
• events.js:400 emit
    events.js:400:28
• websocket.js:1009 receiverOnMessage
    node_modules/ws/lib/websocket.js:1009:20
• events.js:400 emit
    events.js:400:28
• receiver.js:522 dataMessage
    node_modules/ws/lib/receiver.js:522:14
• receiver.js:440 getData
    node_modules/ws/lib/receiver.js:440:17
• receiver.js:148 startLoop

[bropat]

@fuatakgun Have you already tried the same directly with the available eufy-security-ws client application?
Is the behaviour the same?

Sorry I don't have much time at the moment.

[fuatakgun]

i will give it a try and update here.

No worries, 0.3.3 is doing work well enough, do you think we are missing anything important because of lacking 0.4.2? Users are mostly interested faster p2p streaming :-)

[bropat]

@fuatakgun

i will give it a try and update here.

ok, thx.

do you think we are missing anything important because of lacking 0.4.2? Users are mostly interested faster p2p streaming :-)

Mainly the correct handling of multiple clients who want to view the same P2P stream.
Otherwise, some important bug fixes have been made in the eufy-security-client driver (see mainly changelog). 0.3.3 uses version 0.9.4 of the driver, 0.4.2 version 1.1.2.

[bropat]

The latency of the livestream has also been optimised (sometimes at the expense of the audio; I still have to find a better solution there...)

[fuatakgun]

Issue is happening through bare client too. This is one of the blockers for me to update version, please let me know if i can help

[bropat]

Issue is happening through bare client too. This is one of the blockers for me to update version, please let me know if i can help

I'm working on it.

[bropat]

@fuatakgun

Please check out new version and let me know

[fuatakgun]

I have tried now with 2c cameras, still no luck, but it is stopping end stream, i send another command, it throws an error in add-on saying that there is no running live stream.

Sent: {"messageId": "start_livesteam", "command": "device.start_livestream", "serialNumber": "T8113N63205014E2"}
Received: {'type': 'result', 'success': True, 'messageId': 'start_livesteam', 'result': {}}
Received: {'type': 'event', 'event': {'source': 'device', 'event': 'livestream started', 'serialNumber': 'T8113N63205014E2'}}
Sent: {"messageId": "start_livesteam", "command": "device.stop_livestream", "serialNumber": "T8113N63205014E2"}
Received: {'type': 'result', 'success': True, 'messageId': 'start_livesteam', 'result': {}}

[bropat]

@fuatakgun

1. Which version do you use? 0.5.0?
2. With which scheme version? 6?

[fuatakgun]

you are right, sorry.
1- ws version: 0.5.0
2- schema version: 6

[bropat]

I don't think the problem is with eufy-security-ws, rather with eufy-security-client.
To find the cause, I need the entire log of the test in debug mode.

[fuatakgun]

give me couple of minutes, as a side note, rtsp functions are working but with 5-6 seconds delay.

[bropat]

Checked the code again and I think I found the cause at eufy-security-ws....

[bropat]

I do not have access to a PC now (only mobile phone). Can you try commenting line 152 in the file "src/lib/device/message_handler.ts" and run the test again?

[fuatakgun]

your last message, is it related to delay to p2p streaming.

before we continue, let me set my expectation here, maybe I am misinterpreting everything

• P2P and RTSP are independent ways of streaming
• Some cameras support RTSP, so it can be used for them
• All cameras support P2P, so it can be used for all. i can call start_livestream independent of respective camera's RTSP functionality, right?

[fuatakgun]

sent you debug logs over email

[bropat]

your last message, is it related to delay to p2p streaming.

it's related to the stop livestream event

P2P and RTSP are independent ways of streaming
Some cameras support RTSP, so it can be used for them

correct

All cameras support P2P, so it can be used for all. i can call start_livestream independent of respective camera's RTSP functionality, right?

correct

[fuatakgun]

one addition: i am also not receiving chunks for video stream, trying your suggestion

[bropat]

one addition: i am also not receiving chunks for video stream, trying your suggestion

Do you mean commenting this line

[fuatakgun]

sorry, again channels are mixed :) I will give a summary soon

[fuatakgun]

when I commented out following your advice, I was able to receive event once, but for the rest, add-on became unstable as example like below;

2021-10-19 20:20:07.290  INFO Disconnected from station T8010N2320460480
2021-10-19 20:20:08.007  INFO Connected to station T8010N2320460480 on host 192.168.178.23 and port 20519
2021-10-19 20:20:14.117  INFO Client disconnected with ip: ::ffff:192.168.178.119 port: 59312 code: 1006 reason:
2021-10-19 20:20:14.198  INFO Disconnected from station T8010N2320460480
2021-10-19 20:20:19.253  INFO Connected to station T8010N2320460480 on host 192.168.178.23 and port 26197
2021-10-19 20:20:25.194  INFO Disconnected from station T8010N2320460480
2021-10-19 20:20:30.243  INFO Connected to station T8010N2320460480 on host 192.168.178.23 and port 14179
2021-10-19 20:20:36.198  INFO Disconnected from station T8010N2320460480
2021-10-19 20:20:41.244  INFO Connected to station T8010N2320460480 on host 192.168.178.23 and port 12823
2021-10-19 20:21:42.094  WARN Station T8010N2320460480 - Heartbeat check failed. Connection seems lost. Try to reconnect...
2021-10-19 20:21:42.096  INFO Disconnected from station T8010N2320460480
2021-10-19 20:21:42.688  INFO Connected to station T8010N2320460480 on host 192.168.178.23 and port 12823
2021-10-19 20:21:42.700  INFO Disconnected from station T8010N2320460480

[bropat]

@fuatakgun

My advice fixes the error of the stop event, I have tested it myself.

add-on became unstable as example like below;

If you are talking about p2p communication instability, it has nothing to do with eufy-security-ws but with eufy-security-client, because the driver manages the P2P communication and not eufy-security-ws. I have done some research on this and found the cause of this instability. The instability is introduces with this fix.

I am currently looking into how I can solve the problem without retracting the other correction.

[fuatakgun]

it was not directly related to that issue. Until i had started p2, i didn't notice any reconnection issues. But just after p2p events, it starts disconnecting and connecting back. Do you think they are same?

[fuatakgun]

i will generate some other debug logs and share them over respective repositories. But it is not always feasible for me to find the correct one, as i don't have full technical details.

[bropat]

Do you think they are same?

Yes