GithubHelp home page GithubHelp logo

Comments (3)

bropat avatar bropat commented on May 26, 2024 1

@fuatakgun

These attributes cannot be handled as device attributes because streaming is not handled by the device class but by the station class.
The attributes are modelled on the effective attributes of the manufacturer implementation. Starting the live stream is a command, not an attribute in the manufacturer implementation.
Introducing the attributes in the station would be possible but from my point of view unclean.

Now, i need to send start rtsp livestream command and check its result. I am not getting any event.

Furthermore, what you write here is not correct, because there are also the respective events for handling the RTSP stream (you have opened a separate issue for this: #40). There is currently still a bug with the stop event, which will be fixed in eufy-security-client 1.2.2.

For the reasons stated above, I will not pursue this demand.

from eufy-security-ws.

fuatakgun avatar fuatakgun commented on May 26, 2024

hey @bropat , what do you think on this?

from eufy-security-ws.

fuatakgun avatar fuatakgun commented on May 26, 2024

you are right in terms of internal mechanisms of handling livestream and rtsp livestream, but data modelling perspective, they look like attributes of respective devices. Of course, it is up to you make the decision.

from eufy-security-ws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.