GithubHelp home page GithubHelp logo

Comments (2)

Brotcrunsher avatar Brotcrunsher commented on June 3, 2024

Hi Marius, sorry for the late reply.

That is indeed very surprising behavior by GLFW (that's the lib that gives us the key events). I was looking through a few other code bases and realized that most don't seem to expect this. For example the (admittingly outdated) version of Dear ImGUI that the BBE uses wasn't prepared for this as well.

Your proposed workaround is technically quite close to the fix. It could only lead to problems on other architectures that don't have sizeof(int)==4 and was UB before C++20. The correct fix (or so I hope) is to check for GLFW_KEY_UNKNOWN. I just commited that to the repository.

Thank you very much for reporting this. It would be great if you could briefly check if this indeed fixed your issue.

from brotboxengine.

mariusheil avatar mariusheil commented on June 3, 2024

Hello,

thank you and yes, this indeed fixed the issue. :-)

Marius

from brotboxengine.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.