Incorrect exit code when failing to install npm dependencies about browserstack-cypress-cli

[karanshah-browserstack]

@christemple Noted.

[karanshah-browserstack]

@christemple Can you please update to the latest CLI version v1.10.1? There was a bug in v1.9.0 where on some of the ci machines the report wasn't generating properly.

[christemple]

@karanshah-browserstack I've updated to the latest version, it has fixed the previous --sync issue I experienced in v1.9.0, but I'm still experiencing an issue with v1.10.1... this may not have been introduced recently, it's possible I've just discovered it after investigating build issues.

Whenever there is a NPM_INSTALL_FAILED failure, it does not send back the correct exit code to cause the CI tool to fail (Jenkins in this case), it continues as though the build was successful when it failed to even start because of the npm dependencies failure

[nagpalkaran95]

@christemple We made some changes in recent CLI releases which handles the case if npm install fails on the build level (for all sessions) we exit with non zero exit code (with exception as well).
Can you update the CLI to latest version and let us know if it's still an issue?

[CRoulandSpiral]

This appears to be resolved with 1.18.0 for me. The proper error codes are being passed back on failed npm dependency installs.