GithubHelp home page GithubHelp logo

Comments (2)

bryc avatar bryc commented on May 28, 2024

I removed the note re-order code since I can't find a good way to do it right. It was conflicting with the drag-save method that Chrome supports, and it relied entirely on the note table being rewritten.

Since the parser no longer rewrites the noteTable and attempts to retain the original data, note re-ordering has to be completely rethought to handle both display modes, retain as much data integrity as possible, and not interfere with other drag operations, and be done as elegantly as possible.

from mpkedit.

bryc avatar bryc commented on May 28, 2024

A billion years later, and I came up with a simple solution.

  1. Add a separate mode which enables reordering, have it off by default. This is fine because reordering is not that important, it's just nice to have.
  2. Reorder notes by just swapping them. This avoids all the issues I had before: no need to sanitize or sort the list before reordering. Minimal data changes, and doesn't lose any data, even when swapping to empty slots that contain garbage data. It also avoids 'accidental operations', because no changes occur until you let go on a destination, and leaving the destination will cancel the operation. The visual feedback is also pretty clear.

So all in all, now it's done right, and I can no longer feel guilty that the README lists a feature that doesn't exist. :)

from mpkedit.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.