GithubHelp home page GithubHelp logo

Comments (3)

coreych avatar coreych commented on June 19, 2024

Resolved this by removing the line _furthestBlockPoint = CGPointZero; from - (void) invalidateLayout.

from rfquiltlayout.

p-blin avatar p-blin commented on June 19, 2024

you're patch causes a bug when changing orientation and no scroll is needed, a scroll appears and insets are incorrect

i added the line you removed inside the method 'shouldInvalidateLayoutForBoundsChange'

  • (BOOL)shouldInvalidateLayoutForBoundsChange:(CGRect)newBounds {
    if (!(CGSizeEqualToSize(newBounds.size, self.collectionView.frame.size))){
    _furthestBlockPoint = CGPointZero;
    return YES;
    }
    return NO;
    // return !(CGSizeEqualToSize(newBounds.size, self.collectionView.frame.size));
    }

i'm aware it's not a good practice to change object state in a method that should simply return YES or NO but my time to investigate this bug is limited.

from rfquiltlayout.

coreych avatar coreych commented on June 19, 2024

Thanks for this wasn't aware of the bugs created. I hope Bryce can investigate this further.

from rfquiltlayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.