Need warning: SQLite database directory must be writeable about oauth2-demo-php

[bshaffer]

I agree. Are you planning on sending a pull request to fix this issue? I agree index.php is the best place to check, and requires only a call to is_readable
—
Brent Shaffer

On Wed, Apr 24, 2013 at 8:01 AM, mcd-php [email protected] wrote:

SQLite database directory must be writeable.
Otherwise the oauth2-server-demo/web/demo/authorized fails with obscure error:
SQLSTATE[HY000]: General error: 14 unable to open database file
Please add checks for file and folder permission and issue a bold warning if they are insufficient.
The best place i see for this is in index.php before
return new OAuth2_Storage_Pdo(array('dsn' => 'sqlite:'.$sqliteDir));
Sadly i do not know Silex enough to implement this in graceful manner ;(

This error is quite nasty and non-obvious and surely robbed many people like me of their precious man-hours, summing up to man-months across all potential user base.

Reply to this email directly or view it on GitHub:
#9

[mcd-php]

I can only do this in very brutal manner without integration with Silex/Twig error reporting path and decoration - sorry, don't want to learn it.

NO, is_readable() and even is_writable() are not sufficient - the folder must be writable.

[bshaffer]

You seem very concerned about man hours but unwilling to invest any of your own. I have invested many of my own as part of building these libraries.

I do not need fancy error handling. It can die as a result of the directory not being readable, as anything is better than an obfuscated error.