GithubHelp home page GithubHelp logo

Comments (4)

dennisreimann avatar dennisreimann commented on June 11, 2024 1

@ndeet Can you check and confirm that the PR fixed it?

from btcpayserver.

ndeet avatar ndeet commented on June 11, 2024 1

@dennisreimann thank you, works now as before only on InvoiceSettled and InvoiceProcessing events. 🥳

from btcpayserver.

ndeet avatar ndeet commented on June 11, 2024

@dennisreimann thank you very much 🙏

I can confirm the paidOver property is now present again in all the invoice events but InvoiceCreated. Previously it was NOT present in InvoiceReceivedPayment and InvoicePaymentSettled events which are on a payment basis and can happen mulitple times. Not sure if it makes sense to have it there e.g. if you have 2 payments and the first one is already paidOver then the second one would also have paidOver, which makes kinda sense but then also not sure if we need it on a per payment level or keep it on invoice level as before? cc @NicolasDorier

If the conclusion is that we also want it for the payment events let me know and I will create a PR to update the API docs for those events.

from btcpayserver.

dennisreimann avatar dennisreimann commented on June 11, 2024

I pushed 379286c straight to master. fyi @Kukks

from btcpayserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.