Comments (8)
API: Permission on Refund Invoice endpoint The current permission is
btcpay.store.cancreatepullpayments
but it should imo bebtcpay.store.cancreatenonapprovedpullpayments
I believe we can do this without a breaking change as it softens the permission
from btcpayserver.
Refactor onchain support to be similar to LN (connection string style, allows plugins to provide their own onchain tracker system instead)
@Kukks I believe it isn't possible. We are querying NBX database directly in SQL.
from btcpayserver.
Convert various UIs to Blazor
Can we be more specific when listing issues, what does this mean?
from btcpayserver.
Convert various UIs to Blazor
Can we be more specific when listing issues, what does this mean?
I believe it is any UI that uses Vue currently. We can work on a list later
from btcpayserver.
Alright, I understood this list should be a list of breaking changes, but it seems we're pilling quite a lot of things here, and I am trying to understand how to prioritize what is now becoming quite a massive list of tasks.
from btcpayserver.
2nd try, had written everything up got distracted and shut down the laptop, all gone 🙈
I have no access to tasklist so posting here for review and discussion.
API: inconsistent webhook event naming (breaking change)
We have InvoiceReceivedPayment
and InvoicePaymentSettled
, it would be more logical to have them aligned and change InvoiceReceivedPayment
to InvoicePaymentReceived
API: Clean up store wallet docs
We have two sections in the navigation "Store Payment Methods (On Chain)" (SPM) and "Store Wallet (On Chain)" (SW), both use the same endpoint path (stores/{storeId}/payment-methods/onchain/{cryptoCode}/) and the listed endpoints are mixed up a bit.
- SPM has the Create store on-chain wallet endpoint listed which better fits to SW
- The response of above create wallet endpoint contains a legacy field which is not settable through above mentions endpoint called
label
that is always null on newer wallets - Discuss: Preveiw store on-chain payment method addresses and Preview proposed store on-chain payment methods should also be renamed and moved to SW as it relates to wallet and not payment method, if there is a reason to have it here then maybe move Get Store onchain-wallet address to have address fetching together in one section
API: Cleanup Apps / Crowdfund / PoS (possibly breaking change)
- The "App" section has create/create/delete endpoints for both Crowdfund and PoS but their specific sections only 1-2 endpoints, either move everything to apps or to their specific sections
- Update Crowdfund endpoint is missing (at least in docs)
- there is only one general Delete App endpoint but not specific for crowdfund or PoS
I had a few other API related issues on my list but those inconsistencies have been already fixed.
Does anybody find the old BTCPay 2.0 megathread, afair there was one but I could not find it?
from btcpayserver.
API: Permission on Refund Invoice endpoint
The current permission is btcpay.store.cancreatepullpayments
but it should imo be btcpay.store.cancreatenonapprovedpullpayments
from btcpayserver.
API: Invoice refund inconsistency
With the pull payments endpoint you can set paymentMethods as an array and if not set it will apply all available payment methods, with the invoice refund endpoint you only can pass a string and it is required too.
Suggestion: Make it a nullable array too to be consistent and more flexible
from btcpayserver.
Related Issues (20)
- Label clicking seems like it should do something but doesn't HOT 3
- [Bug]: PosApp/PrintView - articles with minimum price are treated as fixed price on checkout HOT 3
- POS Print: Properly handle free items
- Allow "lightning:" in html hyperlinks
- [Bug]: Refund crashes when the invoice is settled qith no payment
- [Bug]: Payout broadcast a transaction but do not change to "In Progress" status when "Subtract fees from amount" is active
- I paid my invoice , but i think i lost my money ples help
- Default printing template for Keypad now produces extra whitespace on Bitcoinize POS
- [Bug]: View button in PoS settings page leads to a 404 page via TOR
- [Bug]: Mapped TOR Domain leads to blank page at checkout
- [Bug]: Wrong listen ip address for lightning node due to cloudflare deployment HOT 2
- When an invoice expires, the corresponding Shopify order remains pending instead of canceling. HOT 10
- [Bug]: Kraken/XMR api broken HOT 4
- [Bug]: kraken(XMR_BTC) is hardcoded, regardless of Preferred Price Source
- [Bug]: btcpay server doesnt show qr HOT 10
- [Bug]: Can not delete a Webhook.
- Bump fee does a CPFP even though the TX was marked as RBF HOT 1
- [Bug]: Non-Sequential Address Generation
- [Coinjoin] Trailing slash is required in coordinator info to connect HOT 1
- [Bug]: Unable to complete lnurlwithdraw request with Mutiny wallet due to no CORS support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from btcpayserver.