Comments (5)
Ah, I wasn't even talking about this causing a problem in the Bublé sources (I hadn't noticed)—rather it was causing trouble in my own projects. But I've fallen back on directly writing the horrible ES5 code needed to create a subclass of Error for now, and I guess I'll just keep doing that until the next geological era when I can ship client-side ES6 code. So this isn't blocking me.
from buble.
Oh, even with that fix, the resulting instances are not instanceof
your class. Even Babel doesn't get that right.
It does work when you directly use class
syntax in the browser, so this is a case where compiling down does some damage.
from buble.
Two possible fixes — don't transpile classes (#43), or don't transpile anything (#42). Depends whether we want to continue supporting Node 4. Any thoughts?
from buble.
As discussed in the babel issue, whether extending builtins is allowed should probably be configurable, right?
from buble.
As @Andarist pointed out in #93, CompileError
already sets message
and stack
, so this should not be a problem for bublé itself.
from buble.
Related Issues (20)
- New magic-string 0.25.7 makes two tests fail in buble HOT 11
- Please update acorn to 5.7.4, 6.4.1, or 7.1.1 to resolve vulnerability in acorn HOT 2
- class extends expression not transpiled HOT 1
- Number range expression is not compiled accordingly HOT 1
- Add support for Vue render functions
- compile error with for...of HOT 2
- Function declarations within blocks are transpiled into code that breaks on some pre-ES2015 targets
- A bug when destructuring in a for .. of loop HOT 1
- super relies on name of base class HOT 5
- async/await -> using array method yields error
- Invalid output when a computed property follows a property with an arrow function as value
- Mutated variables in pseudo-block-scope loops aren't written back when using `continue`
- Must call super constructor in derived class before accessing 'this' or returning from derived constructor
- Support optional chaining. HOT 4
- Security policy questions
- Jsx convertion has some problem HOT 1
- Wrong variable name in block scope
- Remove unicode regexp support and reduce50%+ bundle size.
- Make Buble ignore JSX?
- Please support setPrototypeOf instead of __proto__ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buble.