GithubHelp home page GithubHelp logo

Comments (3)

bufdev avatar bufdev commented on June 14, 2024

That doesn't seem that unexpected - if buf has to search /foo/bar/directory for all relevant .proto files, that's going to take some time (and I'm certain that however buf searches for it is not as optimized as some typical bash tools are) - we can look into optimizing that path a bit, but searching a directory with 100,000+ files for 11 specific .proto files is going to take some time.

from buf.

jhump avatar jhump commented on June 14, 2024

@bufdev, IIRC, the foo/bar/directory folder does not have that many files. The issue is that the "input" to buf was unspecified, and thus default to the current working directory. The current working directory is the root of the repo and huge. When --path indicates a file, it is fast. But it seems like --path with a directory name isn't actually looking only at that one directory but instead collecting everything in the "input" module (so scanning the huge repo root directory) and then filtering the result based on prefix match. (The above is my suspicion based on the observed behavior; I haven't gone through the implementation code yet to confirm what it's doing.)

from buf.

bufdev avatar bufdev commented on June 14, 2024

That shouldn't be the case - we have optimized for that scenario, so it should only do the search on the directory specified in --path. There may be a regression - we have to play with this locally.

from buf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.