GithubHelp home page GithubHelp logo

Comments (3)

timostamm avatar timostamm commented on September 27, 2024

Also see: #508

from protobuf-es.

CharlieMartell avatar CharlieMartell commented on September 27, 2024

Well this isn't about a better typing to the JSON its just that the return value of this fn is just wrong. It only ever returns a JsonObject type

from protobuf-es.

timostamm avatar timostamm commented on September 27, 2024

It is not wrong because a JsonObject is a JsonValue. Here's the definition:

export type JsonValue =
  | number
  | string
  | boolean
  | null
  | JsonObject
  | JsonValue[];

export type JsonObject = { [k: string]: JsonValue };

All messages actually return a JsonObject, the only exception are a handful of well-known types. We use JsonValue for both sides for symmetry, it was never intended to provide message-specific type information.

from protobuf-es.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.