GithubHelp home page GithubHelp logo

Comments (3)

qwertyfinger avatar qwertyfinger commented on May 5, 2024 1

@DevKate In this case it's most probably a mistake.
I think CompletableUseCase should either hold the exact same logic as SingleUseCase:

fun execute(
        completableObserver: DisposableCompletableObserver, 
        params: Params
) {
        disposables.add(
            buildUseCaseObservable(params)
                .subscribeOn(Schedulers.from(threadExecutor))
                .observeOn(postExecutionThread.scheduler)
                .subscribeWith(completableObserver)
        )
    }

or return a Completable from execute() function and be stripped of subscription variable along with unsubcribe() function.
But in this case it's better to also have the same logic in SingleUseCase.

The choice between these two depends on whether you need to have access to a cold Observable in your Presenters (e.g. to combine them or apply some additional logic). I prefer using the latter in any case.
See this thread for more information.

from android-clean-architecture-boilerplate.

 avatar commented on May 5, 2024

Any example for CompletableUseCase?

from android-clean-architecture-boilerplate.

qwertyfinger avatar qwertyfinger commented on May 5, 2024

@852dev Example usage? Saving some data to the database, for example. Anything where we don't need any actual data passed back to us, only the success/error status.

from android-clean-architecture-boilerplate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.