GithubHelp home page GithubHelp logo

Comments (5)

martinrotter avatar martinrotter commented on July 27, 2024

Is this really needed, for me it feels like unnecessary cluttering of simulator "display". Do we really want "real phone" simulator feel? I believe that simulator is just for rougly previewing of how the final application's logic basically looks like, not comprehensive or "real" feel.

What you mean by "status bar". You mean those three buttons? Remember, that anything stylled via CSS (those buttons would have to be stylled) might be potential source of bugs.

If there is real need of implementing title bar or status bar, then I say "why not". But i doubt this can be implemented until 18.5. :)

from buildmlearn-toolkit.

croozeus avatar croozeus commented on July 27, 2024

Well, we should surely implement the application title as in the mobile application. This isn't very difficult imo.

Regarding status bar, having it is good so we should consider it. I would however not implement via stylesheet, but in a smart (i.e. easy way). For example, having it as a part of the phone image, so that it would automatically appear on the top of the screen in simulator. If you understand what I mean. (Basically, just cut the status bar - the bar with the time - and add it to the phone image). What say?

from buildmlearn-toolkit.

martinrotter avatar martinrotter commented on July 27, 2024

I guess that could be a way to go.

from buildmlearn-toolkit.

ravirnjn88 avatar ravirnjn88 commented on July 27, 2024

Added Status and title Bar to the simulator.
Image : https://www.dropbox.com/s/j2va2xiftyx0v0f/TeplateSimulator.jpg?dl=0
@martinrotter @croozeus Please review the PR #54

from buildmlearn-toolkit.

martinrotter avatar martinrotter commented on July 27, 2024

Hello, I will review the code afternoon. After a brief check, it does not look bad.

The pictures look nice.

from buildmlearn-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.