GithubHelp home page GithubHelp logo

Comments (13)

burhanrashid52 avatar burhanrashid52 commented on May 14, 2024 2

Resolved v.0.3.2

from photoeditor.

burhanrashid52 avatar burhanrashid52 commented on May 14, 2024 2

I really don't know. I made the changes as you mentioned and tested with 4 devices and its worked fine. So I thought it might be the device specific issue. It's really weird.

from photoeditor.

Sulfkain avatar Sulfkain commented on May 14, 2024 1

@burhanrashid52
Hey!, I was working on that fix too, and today I have found something weird.
Are you sure this fix works allways?, because I'm seeing that some draws do the same darken blender as before :S

captura de pantalla 2018-07-30 a las 9 53 39

All paths works but not the light blue :S, eraser works.
The only full working solution i found, was to change the acceleration type (and maybe that mess up the eraser)
If you change to a Software acceleration instead of hardware acceleration, that seems to work.

from photoeditor.

Sulfkain avatar Sulfkain commented on May 14, 2024 1

Seem to fail with some light color paths, when overlay other paths darker.
Not only with the light blue.
It's really weird :s

from photoeditor.

ervinod avatar ervinod commented on May 14, 2024

Hello sir, when this bug is expected to resolve

from photoeditor.

ervinod avatar ervinod commented on May 14, 2024

Hello there... when this bug is expected to resolve ?

from photoeditor.

Sulfkain avatar Sulfkain commented on May 14, 2024

The problem seems the PorterDuffxDeff on drawing
mDrawPaint.setXfermode(new PorterDuffXfermode(PorterDuff.Mode.DARKEN));
on line 78 on BrushDrawingView.java file

I didn't modify the mode to check it but I was trying to figure out where the problem is, and it not from compress function, nor removeTransparent function, nor the opacity of the line

And only apply to line draws so, it almot sure that's the problem.
Change it to the default (comment the line) and try it

from photoeditor.

burhanrashid52 avatar burhanrashid52 commented on May 14, 2024

Thank a lot @Sulfkain I was looking for the solution for days.
@ervinod I have fixed issue on dev branch and will release a new version with multiple bug fixes.

from photoeditor.

ervinod avatar ervinod commented on May 14, 2024

Thanks for resolving this issue.... waiting for next release with other remaining bug fixes

from photoeditor.

burhanrashid52 avatar burhanrashid52 commented on May 14, 2024

I have tested on a few devices the with 3-4 colors only. Need to check with light blue color.
That's true if you change acceleration type than eraser won't work, changing the acceleration type was one of my solutions to make eraser work.

from photoeditor.

haniha avatar haniha commented on May 14, 2024

same problem here with light colors
any idea why the light colors ?!

from photoeditor.

burhanrashid52 avatar burhanrashid52 commented on May 14, 2024

Currently, don't have any idea. Working on it

from photoeditor.

Sulfkain avatar Sulfkain commented on May 14, 2024

@burhanrashid52 I have checked and everything working fine! perfect.
Just curious, What was de problem?
Thx for this release!

from photoeditor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.