Polar processes not terminating properly when the main window closed about polar-bookshelf

[burtonator]

Thanks. I assume the latest version?

I think this is probably a pretty easy thing to fix and I've seen similar behavior locally. I'll try to get out a fix soon.

[philba]

Thanks Kevin. Yes, sorry for forgetting that...it was the latest version I found for linux, 1.0.

…

On Thu, Aug 16, 2018 at 12:59 PM Kevin Burton ***@***.***> wrote: Thanks. I assume the latest version? I think this is probably a pretty easy thing to fix and I've seen similar behavior locally. I'll try to get out a fix soon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AETWpxmcRViAhCeDhtcFB6lNf0JD4o3Iks5uRaTWgaJpZM4WAMlE> .

[philba]

polar-bookshelf_1.0.0-beta56_amd64.deb to be exact On Thu, Aug 16, 2018 at 1:02 PM Phillip Bagwell <[email protected]> wrote:

…

Thanks Kevin. Yes, sorry for forgetting that...it was the latest version I found for linux, 1.0. On Thu, Aug 16, 2018 at 12:59 PM Kevin Burton ***@***.***> wrote: > Thanks. I assume the latest version? > > I think this is probably a pretty easy thing to fix and I've seen similar > behavior locally. I'll try to get out a fix soon. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#42 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AETWpxmcRViAhCeDhtcFB6lNf0JD4o3Iks5uRaTWgaJpZM4WAMlE> > . >

[burtonator]

Thanks! Yeah.. that should be ok.

I suspect it's express or something hanging around and refusing to stop.

[philba]

np If there's anything I can do to help with the debug, just let me know

…

On Thu, Aug 16, 2018 at 1:18 PM Kevin Burton ***@***.***> wrote: Thanks! Yeah.. that should be ok. I suspect it's express or something hanging around and refusing to stop. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AETWp7rAuH-oe02PiG7qfVo2KdHZOhsnks5uRal7gaJpZM4WAMlE> .

[burtonator]

ok.. I think I might have fixed it. It's just a hunch though. I think it was the webserver and that it needed to be closed. I might be wrong though.

If you wanted to test it you could pull and then run npm start and see if you see it behaving properly.

[philba]

I don't have Node.js installed (I primarily work in Python ;-) ) but can look at it tomorrow and see what is involved.

…

On Thu, Aug 16, 2018 at 3:50 PM Kevin Burton ***@***.***> wrote: ok.. I think I might have fixed it. It's just a hunch though. I think it was the webserver and that it needed to be closed. I might be wrong though. If you wanted to test it you could pull and then run npm start and see if you see it behaving properly. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AETWpwwSxafAfBxyQcGxUFkryww_Qxj1ks5uRc0BgaJpZM4WAMlE> .

[philba]

BTW: I just had thought...it seems to work fine if you don't open a document; everything exits properly. Are you only launching the webserver when a pdf loads? If it starts at program startup, then maybe it is a difference in the way the blank app and the app+document are are doing cleanup on exit???. On Thu, Aug 16, 2018 at 5:38 PM Phillip Bagwell <[email protected]> wrote:

…

I don't have Node.js installed (I primarily work in Python ;-) ) but can look at it tomorrow and see what is involved. On Thu, Aug 16, 2018 at 3:50 PM Kevin Burton ***@***.***> wrote: > ok.. I think I might have fixed it. It's just a hunch though. I think it > was the webserver and that it needed to be closed. I might be wrong though. > > If you wanted to test it you could pull and then run npm start and see if > you see it behaving properly. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#42 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AETWpwwSxafAfBxyQcGxUFkryww_Qxj1ks5uRc0BgaJpZM4WAMlE> > . >

[burtonator]

Yeah. I think that's a good hint...

I think the only thing it could be is express so I added shutdown code for it...

[burtonator]

I think that fixed it.. just tested it on my end.