GithubHelp home page GithubHelp logo

Comments (4)

bvaughn avatar bvaughn commented on June 6, 2024

If you want to render null with the way the library currently works, I think you have to pass a component that renders null (e.g. () => null)

Presently null kind of acts like a passthrough (so you could use the boundary for e.g. logging only, using onError)

from react-error-boundary.

adam-zhu avatar adam-zhu commented on June 6, 2024

For me, passing null doesn't function as a passthrough because any caught errors are bubbled up and break the app.

Looking at the code, this is expected:
https://github.com/bvaughn/react-error-boundary/blob/master/src/ErrorBoundary.ts#L87

    if (didCatch) {
      const props: FallbackProps = {
        error,
        resetErrorBoundary: this.resetErrorBoundary,
      };

      if (isValidElement(fallback)) {
        childToRender = fallback;
      } else if (typeof fallbackRender === "function") {
        childToRender = fallbackRender(props);
      } else if (FallbackComponent) {
        childToRender = createElement(FallbackComponent, props);
      } else {
        if (isDevelopment) {
          console.error(
            "react-error-boundary requires either a fallback, fallbackRender, or FallbackComponent prop"
          );
        }

        throw error;
      }
    }

from react-error-boundary.

bvaughn avatar bvaughn commented on June 6, 2024

Ah, yeah that makes sense I guess I was confusing React's undefined fallback prop.

I don't feel strongly about this (and probably also won't work on it)

from react-error-boundary.

bvaughn avatar bvaughn commented on June 6, 2024

4.0.12 will render null if you specify fallback={null}

from react-error-boundary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.