GithubHelp home page GithubHelp logo

Comments (3)

timmyers avatar timmyers commented on May 30, 2024 10

Happening to me as well.

I believe this is occuring due to the logic of this function https://github.com/byCedric/semantic-release-expo/blob/develop/src/version.ts#L21.

Somewhat recently, the expo sdk version was removed from app.json (upgrading sdk versions with the expo CLI removed it automatically). If this value is blank, the function will return 0.

I just confirmed that adding back in e.g. "sdkVersion": "38.0.0", makes this work as expected again. Since the value is now optional in app.json, it would be best to switch to the same strategy used by expo: https://forums.expo.io/t/expo-36-upgrade-from-cli-removes-sdkversion-from-app-json-why/34634/3.

from semantic-release-expo.

faceleg avatar faceleg commented on May 30, 2024 3

I've encountered this issue on two projects (one new, one > 1 year old), confirming that @kaminskypavel's solution has resolved the issue for me.

from semantic-release-expo.

kaminskypavel avatar kaminskypavel commented on May 30, 2024

a follow up :

changing the strategy to

  "versions": {
    "version": "${next.raw}",
    "android": "${increment}",    <----------- 
    "ios": "${next.raw}"
  }
[10:23:46 AM] [semantic-release] › ℹ  Start step "prepare" of plugin "semantic-release-expo"
[10:23:46 AM] [semantic-release] [semantic-release-expo] › ℹ  Expo manifest version changed (1.1.0 => 1.1.1) in app.json
[10:23:46 AM] [semantic-release] [semantic-release-expo] › ℹ  Expo manifest android version changed (0 => 1) in app.json <------------
[10:23:46 AM] [semantic-release] [semantic-release-expo] › ℹ  Expo manifest ios version changed (1.1.0 => 1.1.1) in app.json

from semantic-release-expo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.