GithubHelp home page GithubHelp logo

Comments (5)

ignatenkobrain avatar ignatenkobrain commented on September 3, 2024

I believe that the issue started to happen because of ca2dc43

from dua-cli.

ignatenkobrain avatar ignatenkobrain commented on September 3, 2024

I'm sure that running tests on Fedora when building dua-cli is very useful so I think that saving few kilobytes is not worth removing this testing.

from dua-cli.

Byron avatar Byron commented on September 3, 2024

Thanks for reporting and finding the commit that caused the issue.

Would it be possible to see the build scripts and how they work?
The reason I am asking is that maybe, these could be changed to clone the source code instead and checkout the tag of the new version, and test and build from there instead.

That way, crate packages can be optimized to be minimal in size while providing what you need to build and run, and to look good on crates.io/lib.rs. Everything else is exclusively in the git repository.

What do you think? (Please note that I am OK adding 7kb worth of compressed tests back to the package if that is not an option or too much hassle to implement)

from dua-cli.

ignatenkobrain avatar ignatenkobrain commented on September 3, 2024

Here's the build script: https://src.fedoraproject.org/rpms/rust-dua-cli/blob/master/f/rust-dua-cli.spec

We can use additional source to the one from crates.io but we generally prefer not to do so because that means we are not necessarily testing what's published on crates.io.

Also it basically means that we will have to prepare those sources by hand because we need to only include missing files that means every time run some command that will prepare just missing sources. And this won't be possible to automate.

I also did not check if the fixtures are needed for those tests to work (aka tests directory), so if it is - just close this bug and I'll manage second source, shouldn't be hard.

from dua-cli.

ignatenkobrain avatar ignatenkobrain commented on September 3, 2024

yeah, seems that fixtures are needed, so just scratch that.

from dua-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.