Comments (3)
Thanks a lot for reporting and the intense research - it helped me a lot to understand what's going on.
It's a bit sad to see that 9 tests fail when bluntly applying my preferred solution: setting MSYS=winsymlinks:nativestrict
via gix-testtools
, but I will read up on your findings there in the hopes this can be made to work after all and in a way that is at least somewhat maintainable.
Lastly, my feeling is that Git requires symlinks to work but might disable support (or otherwise prohibit them) for some Windows related tests. That's how I would do it anyway to be able to use the existing test-suite as is, and it's what I'd wish to accomplish for gitoxide
as well. Those running the tests must allow symlinks or expect failure of some tests, something I find reasonable to expect on a developer machine.
from gitoxide.
Lastly, my feeling is that Git requires symlinks to work but might disable support (or otherwise prohibit them) for some Windows related tests. That's how I would do it anyway to be able to use the existing test-suite as is, and it's what I'd wish to accomplish for
gitoxide
as well. Those running the tests must allow symlinks or expect failure of some tests, something I find reasonable to expect on a developer machine.
That makes sense, given that the alternatives--at least those I am unaware of--would hamper clarity.
from gitoxide.
This issue was fixed by #1444.
To confirm this, note the absence of
gix-diff-tests::diff tree::changes::to_obtain_tree::many_different_states
in the updated list of failing tests in #1358.
Although that test was never listed there even before it was updated, that is because I opened this issue for the new failure rather than editing the list there. Since #1444, I have rerun all tests on all three major platforms including Windows. Although some tests continue to fail on Windows when GIX_TEST_IGNORE_ARCHIVES=1
is set, this many_different_states
test does not fail on Windows or any other platforms tested, with or without GIX_TEST_IGNORE_ARCHIVES=1
.
This is as suspected based on earlier runs in which I set MSYS=winsymlinks:nativestrict
manually prior to #1444. Since #1444, that no longer has to be set manually to make many_different_states
pass with GIX_TEST_IGNORE_ARCHIVES=1
.
(The status of this issue is thus the same as #1443, but unfortunately it doesn't look like I can myself mark this specifically as closed by #1444.)
from gitoxide.
Related Issues (20)
- `gix clean -xde` deletes the repo's own hidden nested worktrees, but they are not really hidden HOT 5
- The 32-bit Windows releases are 64-bit HOT 6
- Unclear intent regarding optimizations for some profiles HOT 5
- Prebuilt binaries obtained on ARM64 macOS are x86-64 HOT 5
- OSS-Fuzz issue 70841 HOT 1
- OSS-Fuzz issue 70863 HOT 1
- Release workflow relies on deprecated `set-output` feature
- OSS-Fuzz issue 70876 HOT 1
- `from_path_no_follow` test runs `touch` with nonportable date format HOT 3
- Panic when parsing `HEAD:README` in a repo with invalid HEAD. HOT 2
- gitx-credentials fails to build HOT 4
- copy detection differs from git weirdly HOT 12
- progress.rs misleadingly claims "we target 32bit systems only" HOT 6
- CVE-2024-43785: gitoxide-core does not neutralize special characters for terminals HOT 10
- gix-object v0.44.0 fail to compile HOT 2
- gitoxide is still less lenient than git when parsing signatures, in particular in tags
- gix clone fails on https://git.zx2c4.com/sha256-oid-test HOT 1
- Oxidize `git-cliff` HOT 2
- Unable to fetch with only extra_refspecs HOT 1
- Add a `tokio` feature HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitoxide.