Comments (6)
Let's not drop support in the client, by now the overhead for that seems negligible. Furthermore, push
is still using V1 so it's probably a good exercise keep V1 in mind for fetches as well.
from gitoxide.
Dropping support for generating the V2 format (e.g. on the server end) seems fine. However, it'd be nice to be able to connect to older servers to pull and push.
from gitoxide.
Dropping support for generating the V2 format[…]
I assume V1 is meant, otherwise I would need more explanation.
However, it'd be nice to be able to connect to older servers to pull and push.
Personally I would be surprised to see any of these outside of personal installations, and would argue that someone who is years behind git-stable would be hesitant to use a new git implementation in the first place.
Code maintenance is my primary concern which would greatly benefit from not having that cruft around. I believe I would think differently if V1 wouldn't be such accidental 'mess' to begin with, but seeing both implementation next to each other, V1 feels like a third wheel.
Both opinions are perfectly valid, and the value question might be one to answer another time. This could be interesting as this could mean that gitoxide
will only implement the latest stable version of some protocol, while ignoring the past or even dropping support for it during refactoring. (This is already done in one instance by choosing to never support the 'dumb' http protocol.)
from gitoxide.
@Byron Yes, I meant "dropping support for generating anything but the V2 format".
I definitely understand not wanting to deal with V1. My concern would be trying to clone random repositories from around the Internet. I'm not sure how widespread support for the V2 format is. If basically everyone had upgraded, and git itself considers deprecating the V1 format with a message, dropping it from gitoxide makes sense. If some servers people want to clone from still only support V1, it'd be painful if gitoxide couldn't handle cloning from those servers.
from gitoxide.
It would indeed be interesting to see it drop support for an older version of something. Did they ever do that before?
What might help the conversation is that also I wouldn’t rip out V1 support in the moment V2 becomes the default as there would really be no gain. The only trigger I could imagine is having to fix V1 bugs, but fixes might well be contributed so it won’t be me to get annoyed by V1
In any case, I will do my best to keep support around as long as possible.
from gitoxide.
from gitoxide.
Related Issues (20)
- `gix corpus` - an extendable way to run algorithms and record their results for comparison
- gix-packetline v0.16 cannot be compiled by docs.rs HOT 1
- OCD: Satisfy some pedantic clippies HOT 5
- Shell completions support HOT 3
- gix fetch sometimes gets stuck during negociation HOT 4
- Negociation broke fetching from the bcachefs git repository HOT 3
- Unable to fetch non-related remote HOT 9
- Usage of the `gix-testtools` crate
- smart-release: support private registries?
- gix: enable reusing of reqwest::blocking::Client HOT 1
- feature `sha1/asm` is enabled on windows HOT 25
- Usage as a library
- Panic HOT 1
- `gix::transport::client::blocking_io::http::reqwest::Remote` errors too late HOT 3
- Add a user-friendly way to build trees HOT 1
- license of `gix/src/assets/baseline-init` files HOT 1
- Allow optional updating of symbolic references when fetching HOT 5
- Filtering protocol features HOT 6
- `gix-url` parses SSH aliases as file paths HOT 6
- `gix-tempfile` needs a new release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitoxide.