GithubHelp home page GithubHelp logo

Comments (2)

Byron avatar Byron commented on May 29, 2024

Thanks for the detailed write-up, I believe this makes it easy for others to pick up if there is demand.

Indeed the algorithm itself makes certain assumptions and can't be affected by the passed in delegate.

The only way to fix this would be to have entirely different diff-functions, which I believe you could implement yourself based on your needs.

from treediff-rs.

flip111 avatar flip111 commented on May 29, 2024

Well i have the suspicion it's not so much the algorithm as it's the chosen data structure. I read here:

https://doc.rust-lang.org/std/collections/struct.BTreeSet.html

It is a logic error for an item to be modified in such a way that the item's ordering relative to any other item, as determined by the Ord trait, changes while it is in the set.

Maybe it's possible to change the diff function to make it generic over a type so people can choose a structure that cares about order or not. I don't know if there is a candidate data structure that doesn't care about order, but i could look or ask around.

from treediff-rs.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.