GithubHelp home page GithubHelp logo

Comments (4)

ByteZ1337 avatar ByteZ1337 commented on May 26, 2024

Hey!

I didn't know not adding "api-version" will lead to an issues sorry about that. Is there a specific reason to change it to 1.14, not 1.16?

from particlelib.

kaonashi97 avatar kaonashi97 commented on May 26, 2024

Hi, thanks for your fast response.

When I tested it seems that not using this will active Spigots compatibility mode for plugins of older versions. This enforces the Material enum to delegate it's calls to OBC CraftLegacy class.
Thus only calls with the "old" legacy materials (e.g. Material.LEGACY_GLASS) are working. I've never seen that myself before so I don't know exactly how it behaves.
I saw this message in log written by Spigot on startup.

[2020-10-10 22:13:42] [WARN]: Initializing Legacy Material Support. Unless you have legacy plugins and/or data this is a bug!
[2020-10-10 22:13:45] [WARN]: Legacy plugin ParticleLib v1.5.1 does not specify an api-version.

That seems to be my fault as I copied it from another plugin to test if it would break things, when using Spigot 1.16 on 1.14... but as far as I tested it worked. The earliest version is 1.13 and the latest is 1.16. I think you should take the version the most you tested. It seems that api-version tells which Materials, Blocks, etc. your plugin is supporting and older ones aren't allowed anymore. I think taking the lower most is fine as you provide an API and not a specific content aware plugin.

This should not count for Spigot versions below 1.13 as they don't know about this flag.

from particlelib.

ByteZ1337 avatar ByteZ1337 commented on May 26, 2024

I added api-version: 1.14 to the latest ParticleLib-Plugin.jar release.
Let me know if it fixes your issue.

from particlelib.

kaonashi97 avatar kaonashi97 commented on May 26, 2024

I've tested with the same code as above on 1.16.3 Spigot and it worked perfectly.
Thanks for this fast fix!

from particlelib.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.