Comments (3)
Thanks! Fixed.
from caddy.
Oh nice, that was fast! Two things though.
-
A literal
%
needs to be encoded as%25
, else any filename containing a percent followed by hexadecimal digits will break. And although it doesn't seem to be an issue,&
should be encoded as%26
for completeness' sake. -
Tbh I was kind of anticipating less of a "quick and dirty" fix than my own lol. It seems to me that a custom function wrapping Go's
url.PathEscape
should be added to the template module, since the closest built-in functionurlquery
from text/templates isn't quite suitable for escaping paths.
from caddy.
I actually thought the html
template action would escape accordingly based on context, but I guess that doesn't work.
I didn't reference any other implemention, only just now saw that you pushed some of your own commit elsewhere.
from caddy.
Related Issues (20)
- Caddy does not report version # HOT 3
- Caddy missing patches HOT 1
- What happens when multiple root directives with intersecting matchers are specified in a block? HOT 1
- Feature Request: remote_host request matcher HOT 3
- on_demand ask cache instead of rate_limit HOT 3
- Caddy is not stopping HOT 4
- Tailscale certificate is not found when email is specified HOT 3
- logs.skip_hosts is ignored HOT 12
- Placeholders do not work as upstream address for reverse_proxy HOT 2
- How can Caddy Server automatically switch over the next upstream server when it encounters an unhealthy HTTP status code during load balancing? HOT 1
- Getting real ip on docker HOT 2
- lb_retries apparently not working HOT 32
- Caddyfile support for On-Demand TLS permission modules HOT 1
- Add Caddyfile wiring for proxy `dynamic srv`'s `grace_period` option HOT 1
- Transparent proxy for IP HOT 1
- caddy stream state handling issues HOT 4
- Custom conditions for retrying proxy requests
- reverse_proxy: how to prevent stripping of headers with underscores / _ ? HOT 8
- Is fallback on a reverse_proxy's lb_policy being parsed properly? HOT 4
- Missing byte in first websocket message HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caddy.