GithubHelp home page GithubHelp logo

Comments (3)

mholt avatar mholt commented on May 27, 2024

Thanks! Fixed.

from caddy.

DenebTM avatar DenebTM commented on May 27, 2024

Oh nice, that was fast! Two things though.

  1. A literal % needs to be encoded as %25, else any filename containing a percent followed by hexadecimal digits will break. And although it doesn't seem to be an issue, & should be encoded as %26 for completeness' sake.

  2. Tbh I was kind of anticipating less of a "quick and dirty" fix than my own lol. It seems to me that a custom function wrapping Go's url.PathEscape should be added to the template module, since the closest built-in function urlquery from text/templates isn't quite suitable for escaping paths.

from caddy.

mholt avatar mholt commented on May 27, 2024

I actually thought the html template action would escape accordingly based on context, but I guess that doesn't work.

I didn't reference any other implemention, only just now saw that you pushed some of your own commit elsewhere.

from caddy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.