Comments (3)
Minecraft uses a VertexConsumer proxy to generate new geometry for the glint overlay, and it does this at render time so we don't have any opportunity to bake. It would probably be to slow/error prone to try and de-duplicate geometry as well. The only solution in my mind is to stop generating geometry and apply the effect directly in the shader, which the game doesn't do already for some reason.
from sodium-fabric.
I'm not going to rule this as "out of scope" quite yet, since fixing this inherently means solving a major performance issue that does appear in the real world.
But probably we should merge #2487 and #2486, since they're symptoms of the same problem (inappropriately using additional geometry.)
from sodium-fabric.
Closing in favor of #2497 since the issues you have reported about enchantment glint are fundamentally the same problem.
from sodium-fabric.
Related Issues (20)
- Fix visual issues with objects behind translucent entities in Fabulous! graphics HOT 2
- Don't hide the skybox in Spectator mode when inside water, lava or powder snow HOT 5
- Don't apply multiple enchantment glints for items with multiple texture layers HOT 1
- Sodium breaks game's particle managment HOT 2
- Sodium Causing PermGen Error HOT 5
- Game Doesnt Not Launch crashes HOT 5
- Some textures are different between Minecraft Vanilla and Sodium with the "Tooniverse Basic" resource pack. HOT 2
- Fix beacon beam rendering inside-out
- Fix weird vanilla shading for rotated model elements HOT 1
- Sodium Version 1.20.6 falsely states that the graphics card driver is not up to date HOT 1
- Fix flickering player model issue commonly seen when using elytra HOT 3
- Enhanctment Glint should be rendered using a custom shader rather than with additional geometry HOT 1
- Rework graphics adapter scanning to not use the Windows registry HOT 8
- Mention Indium in the wiki HOT 4
- Backport the commit "bc38d56 "Fix fluid rendering occlusion check"" in Sodium 0.5.9
- I had the game crash when I loaded a save from before I installed the mod. HOT 3
- Periodic lag spike when idling with entities (i.e. in a village) HOT 2
- pojavlauncher issue HOT 1
- When glDebugVerbosity is set to 2, an OpenGL performance warning is in the log file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sodium-fabric.