Comments (3)
Minecraft uses a VertexConsumer proxy to generate new geometry for the glint overlay, and it does this at render time so we don't have any opportunity to bake. It would probably be to slow/error prone to try and de-duplicate geometry as well. The only solution in my mind is to stop generating geometry and apply the effect directly in the shader, which the game doesn't do already for some reason.
from sodium-fabric.
I'm not going to rule this as "out of scope" quite yet, since fixing this inherently means solving a major performance issue that does appear in the real world.
But probably we should merge #2487 and #2486, since they're symptoms of the same problem (inappropriately using additional geometry.)
from sodium-fabric.
Closing in favor of #2497 since the issues you have reported about enchantment glint are fundamentally the same problem.
from sodium-fabric.
Related Issues (20)
- When the player is in the lava, some chunks disappear and the clouds are rendered (in spectator mode). HOT 1
- [QUESTION] It is possible to integrate with Vulkan mod HOT 6
- Custom animated sprites are frozen
- Unsupported driver without integrated graphics HOT 1
- Не прогрузаются блоки в мире и на серверах HOT 1
- Те кто играет на фабрик модс pojavlauncher HOT 1
- Waterlogged double slabs and stairs have Z-fighting when rendered next to water HOT 6
- Make setting UI more like a minecraft native UI HOT 2
- Missing HOT 14
- Improve frame synchronization HOT 6
- Could you add DLSS and Ray tracing support HOT 1
- Improper culling of tinted and stained glass block faces and non-full water blocks, through tinted and stained glass, and block selection outline. (chunky?) HOT 3
- Driver version shown for Intel GPUs is incorrectly parsed as a NVIDIA driver version HOT 1
- Fix a culling problem of a certain surface when a translucent block placed just above another different translucent block HOT 1
- Sodium tabs' text broken HOT 2
- Full bright HOT 2
- every block invisible HOT 4
- 1.20.5 version "needs 1.20.6" HOT 4
- White dots on the borders of blocks with a dark texture. HOT 4
- Incompatibility with Fabric API, FluidRenderHandler.getFluidColor is not called. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sodium-fabric.