Add support for ciao using Incluster k8s config about ciao

[gaocegege]

Sure, actually, we will also run the kernel as a pod in kubernetes, thus we need to support incluster config. Thanks for the issue!

[gaocegege]

While, when you do not input a kubeconfig, the package will use inclusterconfig automatically. Thus we do not need to change the code, maybe we could add some instructions or help message for this

[gaocegege]

Code here:

ciao/cmd/kubeflow-kernel/command/run.go

Line 57 in ebedd2a

kcfg, err := clientcmd.BuildConfigFromFlags("", kubeConfig)

Then the function is like:

// BuildConfigFromFlags is a helper function that builds configs from a master
// url or a kubeconfig filepath. These are passed in as command line flags for cluster
// components. Warnings should reflect this usage. If neither masterUrl or kubeconfigPath
// are passed in we fallback to inClusterConfig. If inClusterConfig fails, we fallback
// to the default config.
func BuildConfigFromFlags(masterUrl, kubeconfigPath string) (*restclient.Config, error) {
	if kubeconfigPath == "" && masterUrl == "" {
		glog.Warningf("Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.")
		kubeconfig, err := restclient.InClusterConfig()
		if err == nil {
			return kubeconfig, nil
		}
		glog.Warning("error creating inClusterConfig, falling back to default config: ", err)
	}
	return NewNonInteractiveDeferredLoadingClientConfig(
		&ClientConfigLoadingRules{ExplicitPath: kubeconfigPath},
		&ConfigOverrides{ClusterInfo: clientcmdapi.Cluster{Server: masterUrl}}).ClientConfig()
}

[yeya24]

Oh. Thanks for clarifying that.Sorry for this miss.

[gaocegege]

No worry, thanks for your remind, actually I also forget checking this.

[gaocegege]

I am closing the issue, if you are interested in the development of ciao, welcome comments and other suggestions!

/close