GithubHelp home page GithubHelp logo

Comments (7)

robertpustulka avatar robertpustulka commented on May 21, 2024 1

@burzum then for consistency we should add loadIdentifier() to the interface as well.

from authentication.

robertpustulka avatar robertpustulka commented on May 21, 2024

I'm also having doubts about AuthenticationServiceInterface::loadAuthenticator(). Should authentication services be forced to implement this method? It is needed in default AuthenticationService but some implementations wouldn't need it, for example:

class SimpleService implements AuthenticationServiceInterface
{
    public function __construct(AuthenticateInterface $authenticator) {
        ...
    }
}

Another thing - is there a reason behind the interface being called AuthenticateInterface while all the authenticators use "authenticator" naming convention and reside under Authenticator namespace? (handled in #105)

from authentication.

dereuromark avatar dereuromark commented on May 21, 2024

@robertpustulka Sounds like the interface should get a rename here for consistency.

from authentication.

robertpustulka avatar robertpustulka commented on May 21, 2024

Can we use core ObjectRegistry for collections? cakephp/core is required by this plugin anyway.

from authentication.

burzum avatar burzum commented on May 21, 2024

@robertpustulka can we close this as the PR's have been merged?

from authentication.

robertpustulka avatar robertpustulka commented on May 21, 2024

@burzum There's only a matter of dropping AuthenticationServiceInterface::loadAuthenticator() on todo list. What do you think about it? Should we force this implementation? I think this method is only related to our approach in AuthenticationService. Someone just may want to implement simple service without any authenticators or configuration needed.

from authentication.

burzum avatar burzum commented on May 21, 2024

@robertpustulka if you need such a simple service, then you don't need that plugin at all. 😄

from authentication.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.