GithubHelp home page GithubHelp logo

Comments (5)

othercorey avatar othercorey commented on June 14, 2024 2

From the php ticket, diff() converts the DateTime objects to UTC before comparing.

This means any time zone change that causes a date change can affect the month calculation. Waiting to see if there is more discussion, but the only solution might be to "fake" the date in UTC before calling diff() to get a consistent result.

from chronos.

chinpei215 avatar chinpei215 commented on June 14, 2024 1

No. DST is not adopted in Japan. In addition, it happens even in winter season. For example:

date_default_timezone_set('Asia/Tokyo');

$from = new DateTime('2019-11-01');
$to = new DateTime('2019-12-01');

var_dump($from->diff($to)->m);
// int(0)

It seems like the timezone offset (+09:00 in Japan) is ignored in the diff method.

date_default_timezone_set('Asia/Tokyo');

$from = new DateTime('2019-11-01 09:00');
$to = new DateTime('2019-12-01 09:00');

var_dump($from->diff($to)->m);
// int(1)

from chronos.

othercorey avatar othercorey commented on June 14, 2024 1

I submitted a bug report. Hopefully, we get an answer on how diff() is calculated for different time zones.

https://bugs.php.net/bug.php?id=79452

from chronos.

markstory avatar markstory commented on June 14, 2024

Does this time range cross the DST boundary for Tokyo? If so you might be an hour short of four months.

from chronos.

othercorey avatar othercorey commented on June 14, 2024

Fixed in #283

from chronos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.