Comments (7)
That could potentially be painful for end users, since using both \DateTime and Chronos\DateTime in the same class would require aliasing.
from chronos.
And the other 3 don't have a core PHP counterpart you mean?
One could probably argue that using both in the same class file is usually a not a good idea. Or should make use of some aliasing like
use DateTime as PhpDateTime;
or manually
new \DateTime()
etc. Since the goal of using this Chronos DateTime class is to make things more consistent you should be using it everywhere to be able to leverage that. Using the PHP core one on top in the same files should be the exception to the rule in that case.
But I understand what you mean.
from chronos.
Yeah, that's what I mean... In general I don't like class names to be repeated, even if we have namespaces, because reading the code becomes more difficult
from chronos.
In that case pre- or suffixing is usually the way to go, but ChronosDateTime
could become a little bit much to write maybe?
I still think, though, that mixing the classes inside a class is an edge case. As soon as testing, timezones or buggy core behavior is involved that will blow up eventually.
from chronos.
What about:
class Chronos extends Chronos\DateTime
That way users that want to just use the Chronos version can, and all others can use the Chronos name.
from chronos.
That sounds like a fair (and BC) compromise.
from chronos.
PR #74 is open so discution can take place there.
from chronos.
Related Issues (20)
- Drop PHP 7.2? HOT 9
- Drop src/carbon_compat.php HOT 4
- Trim down the ChronosInterface's API HOT 8
- Chronos3: BC handling with native type/interface HOT 1
- ComparisonTrait::isSameDay() / ComparisonTrait::isSameMonth() HOT 2
- False Statement in 2.x Docs about Timezone Fixation HOT 2
- Hello, I would like to create a Java program for Windows 10 that has a button which, when clicked, starts a timer and that when it approaches minutes 10, 11, 12, and 13, opens a pop-up window with large text and an alarm sound. Can anyone help me with the code or point me in the right direction to get started? HOT 1
- Some deprecation warnings since 2.4.0 HOT 2
- Cannot construct a relative date that always points to the _next_ future date & time HOT 1
- [Question] Is there a way to have chronos properly validate the input against request format? HOT 4
- Missing Cake\Chronos\Date class HOT 3
- Reasoning around no longer extending native DateTimeImmutable HOT 14
- PHP Warning: Undefined array key "class" in /srv/www/vendor/cakephp/chronos/src/Traits/FrozenTimeTrait.php on line 166
- Method endOfDay disregarding microseconds HOT 2
- RFC - Changing default time values for Chronos::create() HOT 1
- Method toNative() has gone missing HOT 5
- 2.4.x: b/c break in Cake\Chronos\Date::create() HOT 1
- 2.4.x: addSecond() is deprecated. Use addSeconds() HOT 3
- ChronosInterval HOT 4
- 2.4.x: diffInWeekdays() is 1 for same day HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chronos.