Comments (5)
Thanks, released v0.7.1 and it is on pypi.
from keymap-drawer.
Hey there, you mean that the output of parsing (e.g. with keymap parse
) does not have the tap/hold legends on the &mo
key and simply produces {t: held}
right? This was a very recent change I made after adding legends for transparent keys, so that they don't have the trans legend ▽
for most keymaps.
However I did not consider you might want to keep the legend for keymaps where there are multiple ways to get to the same layer, since parsing only assigns held keys to the first way it finds anyway. User feedback like this issue helps me to understand use cases better, so thanks for that. I'll add a config option so you can keep the old behavior.
from keymap-drawer.
One question: If we preserve the legends of held keys, would you prefer that be unconditional or should it still erase the ▽
legend if it is a &trans
position?
from keymap-drawer.
I opted to go with the "smart" approach where the binding will be deleted only if it is transparent in the first place. This way we don't have to introduce a new config entry and it should follow the current behavior for the typical use cases.
Hopefully that covers your scenario, if so I will make a bug fix release. If not, let me know.
from keymap-drawer.
Thanks for the quick fix, I think the smart approach sounds good. Will let you know if there's any issue once I've tested the new release.
from keymap-drawer.
Related Issues (20)
- Separate Combos on ZMK HOT 4
- Feature request: binding inheritence or aliases HOT 2
- Get help action to add to ZMK archive. HOT 6
- Upgrading to `v0.13.0` lose `trans_legend` config HOT 4
- MoErgo's Glove80's triggering the assert "Number of keys on layer {} does not match physical layout specification" HOT 2
- feature request: add support for overlaid devicetree node property values HOT 5
- TRANS keys some times not picked up correctly HOT 2
- View is cut off when combo description is offset HOT 4
- bug: `draw_separate` does not work anymore HOT 3
- Tabler icons are not loaded anymore HOT 8
- tabler `viewbox` regex issue HOT 2
- parse: keyboard name detection fails for files in nix store HOT 4
- Allow loading SVG icons from the filesystem HOT 3
- Fix stdout redirect issues on Windows related to encodings
- Feature request: use browser local storage to remember the yaml HOT 4
- Pull in symbols for numbers automatically from zmk config HOT 4
- Feature Request: List with checkbox to only export some layers HOT 5
- Please add Kanata as input source HOT 6
- Feature Request: Using local layout file HOT 3
- Feature request: Display multiple keys that could activate a layer HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keymap-drawer.