GithubHelp home page GithubHelp logo

Comments (5)

caksoylar avatar caksoylar commented on June 17, 2024 1

Thanks, released v0.7.1 and it is on pypi.

from keymap-drawer.

caksoylar avatar caksoylar commented on June 17, 2024

Hey there, you mean that the output of parsing (e.g. with keymap parse) does not have the tap/hold legends on the &mo key and simply produces {t: held} right? This was a very recent change I made after adding legends for transparent keys, so that they don't have the trans legend for most keymaps.

However I did not consider you might want to keep the legend for keymaps where there are multiple ways to get to the same layer, since parsing only assigns held keys to the first way it finds anyway. User feedback like this issue helps me to understand use cases better, so thanks for that. I'll add a config option so you can keep the old behavior.

from keymap-drawer.

caksoylar avatar caksoylar commented on June 17, 2024

One question: If we preserve the legends of held keys, would you prefer that be unconditional or should it still erase the legend if it is a &trans position?

from keymap-drawer.

caksoylar avatar caksoylar commented on June 17, 2024

I opted to go with the "smart" approach where the binding will be deleted only if it is transparent in the first place. This way we don't have to introduce a new config entry and it should follow the current behavior for the typical use cases.

Hopefully that covers your scenario, if so I will make a bug fix release. If not, let me know.

from keymap-drawer.

titus-ong avatar titus-ong commented on June 17, 2024

Thanks for the quick fix, I think the smart approach sounds good. Will let you know if there's any issue once I've tested the new release.

from keymap-drawer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.