Comments (4)
CalebBell
commented on June 8, 2024
Hi,
Numerical instabilities are always hard to believe until you're debugging them. The issue wasn't quite a numerical stability actually, but a result of floating point precision. The volume of the torispherical head at the start was being calculated at a height of... -2.220446049250313e-16 m, which the formula was doing not nice things at.
This could be fixed by chancing the various volume formulas to return 0 for negative heights. Do you want to prepare a PR?
Sincerely,
Caleb
from fluids.
anthracitegrey
commented on June 8, 2024
Hi Caleb, thanks for your rapid answer. I'm afraid I'm not fit enough...
Appreciate your help and thanks for a great library
from fluids.
CalebBell
commented on June 8, 2024
Hi,
The change has been made and all the volume formulas have been protected from this error too. They will be in the next release. Thanks for the excellent bug report!
Sincerely,
Caleb
from fluids.
CalebBell
commented on June 8, 2024
Heads up the fix is in the latest release on PyPi now!
from fluids.
Related Issues (20)
- Mistake in doc. formula fluids.fittings.contraction_conical HOT 1
- Bubbling flow in reactors HOT 2
- docs, unit of measurement for f and k in fluids.geometry.TANK HOT 1
- How to get the accurate average compression factor in the empirical formula HOT 3
- lots of KeyError:NUMBER while running pytest HOT 2
- Initiation error in Stream HOT 3
- model name bug in <two_phase.py> HOT 1
- Feature Request: Use np.sqrt() instead of math.sqrt() HOT 4
- Flow_meter.py Division by Zero Error HOT 1
- Feature request: Fittings Database addition HOT 7
- Particle Size Distribution Tutorial HOT 1
- Long radius nozzle error when C_specified = None HOT 1
- LGTM reports keyword argument `ags` is not a supported parameter name of function `quad_adaptive` HOT 1
- Error in contextual help: Reynolds function HOT 1
- Plate Heat Exchanger HOT 6
- IPython dependency with Numba HOT 3
- Error in the Hooper method for conical diffuser/expansion HOT 2
- Pressure Drop for throttle plates HOT 1
- Calculation of G in K_branch_diverging_Crane HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluids.