GithubHelp home page GithubHelp logo

Problems on LG G3 about camerakit-android HOT 7 CLOSED

camerakit avatar camerakit commented on May 9, 2024
Problems on LG G3

from camerakit-android.

Comments (7)

muetzenflo avatar muetzenflo commented on May 9, 2024

i can confirm this (also on LG G3). I cloned the repo to see what's going on, but in debug mode everything works as expected. This seems to be a proguard issue => crash log in dev console

from camerakit-android.

ThomasKomarnicki avatar ThomasKomarnicki commented on May 9, 2024

I've seen the same issue on my Nexus 5 (4.4) and Note 5 (6.0). It looks like the culprit is Camera1:261:
AspectRatio targetRatio = aspectRatios.size() > 0 ? aspectRatios.last() : null;
which throws:

at java.util.TreeMap.lastKey(TreeMap.java:630)
at java.util.TreeSet.last(TreeSet.java:272)
at com.flurgle.camerakit.Camera1.getPreviewResolution(Camera1.java:261)

I'm not sure how aspectRatios.last() could throw an exception if the TreeSet has entries.

from camerakit-android.

dwillmc avatar dwillmc commented on May 9, 2024

@ThomasKomarnicki you see this on the app downloaded from Google Play right? That exception should be resolved in the library.

from camerakit-android.

ThomasKomarnicki avatar ThomasKomarnicki commented on May 9, 2024

yes it's only happening in the demo downloaded from Google Play, I cloned the repo and ran the most up to date version and it is no longer happening

from camerakit-android.

ThomasKomarnicki avatar ThomasKomarnicki commented on May 9, 2024

@dwillmc ah I found the commit where you fixed it, should be fine then..

from camerakit-android.

dwillmc avatar dwillmc commented on May 9, 2024

If you're curious, it happens due to me wrongly assuming that there will always be matching aspect ratios available when comparing the set of available preview sizes and available picture capture sizes.

from camerakit-android.

dwillmc avatar dwillmc commented on May 9, 2024

An update was just pushed which should rollout in the next few hours and fix this problem.
Please re-open if you get the update and it still doesn't work!

from camerakit-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.