GithubHelp home page GithubHelp logo

Comments (2)

cameronterry avatar cameronterry commented on June 10, 2024

Well it would appear that it is using home_url(), which should have spat out the "Primary domain" rather than the "Admin domain".

https://github.com/Yoast/wordpress-seo/blob/4.0.2/admin/formatter/class-post-metabox-formatter.php#L84-L105

So there appears to be an oversight in the pre_option_home filter which is being missed here. Possibly related to the issue in #15.

from dark-matter.

cameronterry avatar cameronterry commented on June 10, 2024

It would seem the issue was introduced with the following code snippet; f23ce26#diff-1117b1f931f61246ed2c07a83c7603a3R126

It might be enough to remove it as long as other issues do not bubble to the surface. Will continue testing without it and see what happens.

Actually never mind - based on the WordPress Core code for get_option(), the check is redundant as the value is always false. So will remove the if conditional.

from dark-matter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.