Comments (2)
Well it would appear that it is using home_url(), which should have spat out the "Primary domain" rather than the "Admin domain".
So there appears to be an oversight in the pre_option_home filter which is being missed here. Possibly related to the issue in #15.
from dark-matter.
It would seem the issue was introduced with the following code snippet; f23ce26#diff-1117b1f931f61246ed2c07a83c7603a3R126
It might be enough to remove it as long as other issues do not bubble to the surface. Will continue testing without it and see what happens.
Actually never mind - based on the WordPress Core code for get_option(), the check is redundant as the value is always false. So will remove the if conditional.
from dark-matter.
Related Issues (20)
- get_rest_url() returns primary domain in admin HOT 1
- Sanitize domain to be mapped
- DM_SSO doesn' set status_header and status_code
- Doc Block the same for map() and unmap()
- Better mapping management on the root domain HOT 1
- Missing filter to set domain permission check HOT 1
- PHP 8 Support HOT 1
- Better handling / support for root site
- Support for mapping domains to pages (rather than sites)
- Problem with Yoast SEO internal link counting HOT 2
- npm run build warnings
- Missing build instructions HOT 1
- Media domains not working with switch_to_blog()
- get_rest_url() incorrect returns the admin domain in switch_to_blog()
- Primary domain set / unset not updating domain cache
- Primary domain - unnecessary updates / queries HOT 1
- Snyk / babel/runtime dependency workflow error
- Bug: primary domain deletion should reload the page
- Bug: update class not checking request() response adequately
- Confirmation of class-dm-rest-domains-controller.php PHP 8.1 Compatibility HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dark-matter.