Synthesis only generates Fortran 90 style comments about camfort

[dorchard]

I've made a separate fixture to show what should happen, and reverted the test for now to accommodate this inaccuracy so that our build will work.

[madgen]

Bugs should fail builds.

[dorchard]

I would like Travis to generate binaries for us as I need to do a new release to fix Stackage. I don't have time to fix this bug, but we need to fix Stackage ASAP.

[madgen]

Fair

[madgen]

@dorchard do we want to ship with this bug?

[buggymcbugfix]

I can't reproduce this.

$ camfort units-synth samples/units/stuck1.f --inplace

on the file

      PROGRAM ONE
        IMPLICIT NONE
        REAL  radius, height
        REAL  mass
        REAL  densit, volume, pi, i
        volume = pi * radius**2 * height
        mass = volume * densit

        do 10 i=1,10
           radius = i
 10     continue
      end
      function r(m,t,a)
        integer m,a(10)
        real t

        r = 0.1*t * (m**2 + 14*m + 46)
        if (r .LT. 0) r = 0.0

        return
      end

is giving the following output:

      PROGRAM ONE
        IMPLICIT NONE
        REAL  radius, height
        REAL  mass
        REAL  densit, volume, pi, i
        volume = pi * radius**2 * height
        mass = volume * densit

        do 10 i=1,10
           radius = i
 10     continue
      end
c= unit('a) :: r
      function r(m,t,a)
c= unit('b) :: a
c= unit(1) :: m
        integer m,a(10)
c= unit('a) :: t
        real t

        r = 0.1*t * (m**2 + 14*m + 46)
        if (r .LT. 0) r = 0.0

        return
      end

[dorchard]

units-synth might be doing things correctly. How about stencils-synth?

[buggymcbugfix]

My bad.

[dorchard]

Not at all, I think when the bug was first posted units-synth was wrong as well (hence the bug report from @madgen says "stencils and units").

[buggymcbugfix]

Can confirm that this is still an issue with stencils-synth.

[mrd]

Thought I fixed it recently by passing the meta info thru the synth functions.

…

On 30 May 2017 8:37 pm, "Vilem" ***@***.***> wrote: Can confirm that this is still an issue with units-synth. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQmOA_zPIvovCHgepZd8dpIRG2FQNBEks5r_G_tgaJpZM4Jr3kE> .

[dorchard]

You did @mrd - I think the problem is just with stencils-synth now.