LEDs on CANable about candlelight_fw

[fenugrec]

Hi,
did you see PR #37 ? I'm also not a huge fan of the current behaviour but it does have some logic to it.

single blink on power-up

Ok, didn't need that with my hardware (has a dedicated power LED) but I can imagine no argument against this. It could probably go somewhere in main.c near the call to led_set_mode( ) ? (common to all boards)

interface down/up

heh, we now have 3 different ideas on what the LEDs should show ! Personally I prefer tx vs rx activity, Hubert wanted it to behave like an ethernet jack, and you have even something else in mind. I'm not sure how to reconcile all this without spiraling in an #ifdef mess... maybe something like I described in that PR , with an added "heartbeat" blink when power is on but interface is down ?

[normaldotcom]

Didn't see that pull request, glad someone has been thinking about it! I think I can make a clean PR adding blinking of LEDs on powerup, and then just change the polarity of the green LED in the CANable-specific section of config.h. Should avoid a big #ifdef mess, definitely don't want to make things messy.

[fenugrec]

As you probably saw I merged your LED PR. If behaviour is OK on your board types now I'll close this. Thanks !

[fenugrec]

Feel free to reopen if any further issues.