GithubHelp home page GithubHelp logo

Comments (13)

Canato avatar Canato commented on May 23, 2024 1

indeed, hopefully we can update this soon

from android-image-cropper.

Canato avatar Canato commented on May 23, 2024 1

Yes @SanjayDevTech will add you to the team, so I can assign to you, please keep us update ^^

from android-image-cropper.

Canato avatar Canato commented on May 23, 2024 1

@SanjayDevTech please use Coroutines as much you can =)

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024 1

@Canato Opened : )

from android-image-cropper.

Canato avatar Canato commented on May 23, 2024

Just to be clear with who will help. Let's use Coroutines

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

@Canato Can I work on this issue? Could you assign it to me?

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

@Canato sure... I will commit the changes to my forked repository...

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

This is my plan @Canato :

  1. Migrate some code to Kotlin (Just to implement Coroutine)
  2. Replace AsyncTask with Coroutines
  3. Refactoring CropImageView to use new Coroutine class 😃

from android-image-cropper.

Canato avatar Canato commented on May 23, 2024

This is my plan @Canato :

  1. Migrate some code to Kotlin (Just to implement Coroutine)
  2. Replace AsyncTask with Coroutines
  3. Refactoring CropImageView to use new Coroutine class 😃

Perfect! can we do this in 3 PRs to make faster to review?

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

@Canato I have done 50% of migration
It is saying me to wait for your approval

from android-image-cropper.

Canato avatar Canato commented on May 23, 2024

@SanjayDevTech Please open a PR so I can review and approve

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

@Canato Final PR is opened : )

from android-image-cropper.

SanjayDevTech avatar SanjayDevTech commented on May 23, 2024

@Canato ChangeLog and Readme updated

from android-image-cropper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.