Comments (6)
The old way was to make the window === global. Should we do that, or assign(window, global())
@justinbmeyer ?
from can-vdom.
I'm going to go with the first option for now.
from can-vdom.
is setTimeout
enumerable on global? I'm wondering if looping over everything and assigning it would work.
from can-vdom.
Possibly, why do you like that method better?
from can-vdom.
I don't like it necessarily. Just thinking through options.
from can-vdom.
OK, I'm leaning towards what the PR does since we have to worry about enumerability
from can-vdom.
Related Issues (20)
- Add documentation HOT 1
- makeWindow should also set self HOT 1
- Improve docs
- All vDom based tests failing on IE11 with "Out of stack space" error HOT 6
- Undefined showing as menu item in docs HOT 2
- Add getComputedProp to make-window
- Expose the Node global
- Setup missing badges
- parser in make-parser treats <!DOCTYPE> as text.
- An in-range update of can-assign is breaking the build 🚨 HOT 2
- An in-range update of steal-tools is breaking the build 🚨 HOT 10
- An in-range update of can-globals is breaking the build 🚨 HOT 2
- Add support for FormData
- An in-range update of can-assign is breaking the build 🚨 HOT 2
- An in-range update of can-globals is breaking the build 🚨 HOT 1
- An in-range update of can-view-parser is breaking the build 🚨 HOT 1
- An in-range update of can-log is breaking the build 🚨 HOT 2
- An in-range update of can-simple-dom is breaking the build 🚨 HOT 2
- Remove can-util
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from can-vdom.