Should it be `BlockedStatus`? about grafana-agent-k8s-operator

[rbarry82]

We don't do this with loki_push_api, but Loki pushes batch, and wait in the queue until it actually is available (so in theory, waiting for a bit doesn't actually cause lost logging data, just delayed logging data). AFAIK, remote-write does not, and may cause Prometheus to complain about out of order timestamps even if it did, so waiting is not ok

[sed-i]

According to both docstrings and the doc page, "waiting" means the charm is healthy, and "blocked" - unhealthy.

I think "waiting" is correct here.

---

Doc page:

Status	Meaning
waiting	The charm is alive and well, and is waiting for some event to occur. No human intervention required.
blocked	The charm is stuck. Human attention/intervention is required.

Docstring for WaitingStatus:

    The unit is unable to progress to an active state because an application to which
    it is related is not running.

Docstring for BlockedStatus:

    An operator has to manually intervene to unblock the unit and let it proceed.

---

    def _update_status(self):
        """Determine the charm status based on relation health and grafana-agent service readiness.

        Sets unit status to either Waiting or Active.
        """
        if relations := self.model.relations.get("metrics-endpoint"):
            if len(relations):
                if not len(self.model.relations[REMOTE_WRITE_RELATION_NAME]):
                    self.unit.status = WaitingStatus("no related Prometheus remote-write")
                    return

        if not self.is_ready:
            self.unit.status = WaitingStatus("waiting for the agent to start")
            return

        self.unit.status = ActiveStatus()

[sed-i]

Fixed in #141.