GithubHelp home page GithubHelp logo

Comments (9)

rbarry82 avatar rbarry82 commented on June 10, 2024

Yes, but that's what we want, since the subordinate is "really" running on the principal machine. We could set a limit so they don't walk over each other's configs, though, but this is probably a "don't do that" item which almost nobody will try in real life.

The snap library itself is idempotent, though, and if it's already installed, the worst that happens is that it tries to refresh it when we try to ensure it's the latest version. If it's already on the principal, this is a noop.

That said, the assumption that an operator will manually install the snap on some other charm is pretty antithetical to normal cloud operations, and the same "what if an admin juju ssh-es into a machine and initializes postgres/kafka/changes the PAM configuration/etc" are potential risks/"don't do that" in all charms which are not meaningful/supportable scenarios.

from grafana-agent-k8s-operator.

rbarry82 avatar rbarry82 commented on June 10, 2024

This PR will permanently resolve this.

from grafana-agent-k8s-operator.

sed-i avatar sed-i commented on June 10, 2024

Afaict, that PR does not address the race in writing config files.
But I'm fine with placing it in the "don't do that" bin.

from grafana-agent-k8s-operator.

rbarry82 avatar rbarry82 commented on June 10, 2024

No, it doesn't. But "I related two grafana-agent charms to the same principal on different subordinates and they're thrashing the same config file" probably equally applies to, like... the entire category of subordinates, honestly.

from grafana-agent-k8s-operator.

dstathis avatar dstathis commented on June 10, 2024

We have no way to stop. It will obviously break if you do it. As Ryan said, that is probably true of every subordinate ever.

from grafana-agent-k8s-operator.

sed-i avatar sed-i commented on June 10, 2024

Ok. Let's tackle this in the docs, if at all. Closing.

from grafana-agent-k8s-operator.

sed-i avatar sed-i commented on June 10, 2024

Do you think we should recommend limit: 1 for cos-agent provider (kafka, zk, ...)?
cc @Abuelodelanada

from grafana-agent-k8s-operator.

rbarry82 avatar rbarry82 commented on June 10, 2024

I guess the question is, somewhat "what are the odds?"

It wouldn't hurt to sneak it into a PR, but it's probably low priority enough not to deserve an issue on its own IMO

from grafana-agent-k8s-operator.

Abuelodelanada avatar Abuelodelanada commented on June 10, 2024

Do you think we should recommend limit: 1 for cos-agent provider (kafka, zk, ...)?
cc @Abuelodelanada

My gut feeling is that there is no point in having more than one.

from grafana-agent-k8s-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.