GithubHelp home page GithubHelp logo

Comments (4)

jmuzina avatar jmuzina commented on July 16, 2024

I think we can try to address this with new variable introduced by merging of #5192 , correct?

from vanilla-framework.

pastelcyborg avatar pastelcyborg commented on July 16, 2024

I discovered this during my focus variable work, but left it alone, as it used a different variable. To be honest, I find the fact that the outline is black under any circumstances, dark or not, kind of odd. Maybe we could revisit this?

from vanilla-framework.

bartaz avatar bartaz commented on July 16, 2024

I discovered this during my focus variable work, but left it alone, as it used a different variable. To be honest, I find the fact that the outline is black under any circumstances, dark or not, kind of odd. Maybe we could revisit this?

I believe it was because it was hard to find any other colour with enough contrast against both background and the button colour to comply with accessibility requirements.

from vanilla-framework.

pastelcyborg avatar pastelcyborg commented on July 16, 2024

Good to know, thanks @bartaz. Yeah, we should come up with a new color for this on dark theme, even if it's a grayscale shade.

from vanilla-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.