Permissions error on startup about mcfly

[cantino]

Weird! Thanks for testing out McFly. I'm still on 10.13.6. Do both terminal windows have the same value for $MCFLY_HISTORY? Does running mktemp -t mcfly.XXXX twice give you the same output? (It shouldn't.)

[gwk]

Every time I open a window it creates a new mcfly.XXXX, which matches the set $MCFLY_HISTORY. If I run the mktemp command above twice I get different paths.

Last login: Mon Dec  3 19:15:05 on ttys011
-bash: /var/folders/kb/bswbcrr56ld5cv7zzhyp57gr0000gn/T/mcfly.XXXX.SNQglCSU: cannot overwrite existing file
gwk ~ $ echo $MCFLY_HISTORY
/var/folders/kb/bswbcrr56ld5cv7zzhyp57gr0000gn/T/mcfly.XXXX.SNQglCSU
gwk ~ $ 

[cantino]

That's very odd. If you edit mcfly.bash and add after line 9:

chmod 644 $MCFLY_HISTORY

Does that help at all? I can't tell if mcfly.bash is erring out on line 8 or if it's later.

[gwk]

I added set -x, and it looks like it's the tail command on line 15.

+++ [[ '' == \l\o\a\d\e\d ]]
+++ export __MCFLY_LOADED=loaded
+++ __MCFLY_LOADED=loaded
++++ cat /dev/urandom
++++ env LC_CTYPE=C tr -dc a-zA-Z0-9
++++ fold -w 24
++++ head -n 1
+++ export MCFLY_SESSION_ID=R6GaHe2Jn5JzbylIKmM1JEu3
+++ MCFLY_SESSION_ID=R6GaHe2Jn5JzbylIKmM1JEu3
++++ mktemp -t mcfly.XXXX
+++ export MCFLY_HISTORY=/var/folders/kb/bswbcrr56ld5cv7zzhyp57gr0000gn/T/mcfly.XXXX.JsVKq6ZD
+++ MCFLY_HISTORY=/var/folders/kb/bswbcrr56ld5cv7zzhyp57gr0000gn/T/mcfly.XXXX.JsVKq6ZD
+++ export HISTFILE=/Users/gwk/.bash_history
+++ HISTFILE=/Users/gwk/.bash_history
+++ [[ -f /Users/gwk/.bash_history ]]
+++ tail -n100 /Users/gwk/.bash_history
-bash: /var/folders/kb/bswbcrr56ld5cv7zzhyp57gr0000gn/T/mcfly.XXXX.JsVKq6ZD: cannot overwrite existing file
+++ export HISTCONTROL=ignorespace
+++ HISTCONTROL=ignorespace
+++ shopt -s histappend
+++ PROMPT_COMMAND='__last_exit=$?;history -a $MCFLY_HISTORY;mcfly add --exit $__last_exit --append-to-histfile;history -cr $MCFLY_HISTORY;gloss_set_prompts'
+++ [[ himxBCH =~ .*i.* ]]
+++ bind ''\''\C-r'\'': '\''\C-amcfly: \e# mcfly search\C-j'\'''
+++ set +x

[cantino]

That's helpful! Does adding chmod 644 $MCFLY_HISTORY after line 9 help?

[gwk]

I know what is wrong: I have bash configured to deny blind overwrites with >. I changed it to use >| instead and it works. I forget what this option is called, but I can look it up.

[cantino]

Oh interesting, I didn't know about noclobber! Mind sending a PR with the change? (Or I can add it, but I want you to get credit! 😄 )

[gwk]

It's set -o noclobber. Seems worth supporting since you are sourcing into the user's interactive shell.

[gwk]

Yes, I'll make a PR now.

[cantino]

I believe that this has been fixed.