GithubHelp home page GithubHelp logo

Do not overwrite HISTFILE about mcfly HOT 5 OPEN

cantino avatar cantino commented on August 11, 2024 1
Do not overwrite HISTFILE

from mcfly.

Comments (5)

cantino avatar cantino commented on August 11, 2024

Thanks @a-dekker, that's a good addition.

from mcfly.

cantino avatar cantino commented on August 11, 2024

I'll include a fix for this in #81.

from mcfly.

a-dekker avatar a-dekker commented on August 11, 2024

It doesn't seem to be fixed, it still contains the line
export HISTFILE="${HISTFILE:-$HOME/.bash_history}"
at https://github.com/cantino/mcfly/blob/master/mcfly.bash#L13

from mcfly.

cantino avatar cantino commented on August 11, 2024

Hey @a-dekker, sorry about that. I actually reverted the change, as it was giving me odd issues in BASH where the variable didn't seem to be set.

from mcfly.

a-dekker avatar a-dekker commented on August 11, 2024

That seems strange, never experienced any issues with the alternative implementation.
The change is also very straightforward: test if the value is set, if not, set the default.
It should do the same as your implementation, except not overwrite it by default.

from mcfly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.