Comments (4)
Spent some time assessing our test effort today.
Adding code coverage would be a good place to start with this. I wasn't able to get it working with istanbul-coverage
, karma-coverage
, nyc
+instabul-instrument-loader
or karma-typescript
's coverage though. Those modules really dislike the inclusion of non-code files like SVG. Maybe someone more adept with webpack could take a look.
There are several commented-out unit tests already. They fail with a cryptic "Script Error" that I wasn't able to debug (it has no trace at all).
The existing tests are fragile and fail intermittently. They're all wrapped in timeouts, which could be part of the problem (is this normal for Jasmine tests?).
from carbon-charts.
We will potentially replace webpack with Rollup. What are the possibilities there?
The tests that use setTimeouts are testing functionality that the library needs to run and update DOM.
from carbon-charts.
I'm not sure about Rollup. I noticed some incompatibilities with how webpack does module loading (nyc
for example relies on your module loader overriding "require"), so it might help.
Apparently ES6+TypeScript+Karma+Webpack is just not a usecase that any of the code coverage tools account for.
I did manage to get instrumentation working with istanbul-instrument-loader
, but none of the coverage tools I tried would report correctly.
from carbon-charts.
UPDATE
@t-mullen & I are putting together a full test plan (WIP currently), and will start with unit-tests, but will also implement code-coverage analysis down the road:
https://github.com/IBM/carbon-charts/wiki/Test-Plan-for-v1.0
from carbon-charts.
Related Issues (20)
- [Accessibility]: aria-label of charts toolbar all have same ID HOT 2
- [Accessibility]: Simple bar chart bars with value 0 do not have aria-label
- [Enhancement]:
- Does `@carbon/charts-react` support React 17? HOT 1
- [Bug]: BarChartGrouped is missing the following properties: chart, ref
- [Bug]: StackedBarChartOptions is missing from the typescript exports for carbon charts react
- [Bug]: Redefined variables violating no-shadow rule
- [Bug]: Warnings from missing properties
- [Bug]: Cannot find module 'topojson-specification' or its corresponding type declarations HOT 5
- [Bug]: charts-react SSR render fails starting with 1.13.10 HOT 4
- [Bug]: Selecting the legend on a StackedBarChart doesn't work if data is loaded in after the initial load
- [Accessibility]: Alternate text or representation for charts
- [Bug]: CUSTOM ToolbarControls render as enabled when shouldBeDisabled returns true
- @carbon/charts-docs-1.17.3.tgz: 1 vulnerabilities (highest severity is: 9.8) - autoclosed HOT 1
- [Accessibility]: Multiple toolbar components do not have unique labels HOT 3
- [Bug]: threshold html elements of line chart still existing when thresholdoptions are empty
- [Question]: Does anyone have an example of a combochart with stacked and grouped combined, is that possible?
- [Bug]: Cannot use zoom bar with ScatterChart and a single data point HOT 1
- [Bug]: Text color of tree map leaves is incorrect when using custom colors
- [Accessibility]: SVG element has no accessible name error for the charts HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carbon-charts.