GithubHelp home page GithubHelp logo

Comments (3)

CarlosBonetti avatar CarlosBonetti commented on September 27, 2024

Thanks for the feedback, @mikestu.

About the z-index: the z-index issue for this plugin is pretty complicated. Currently, the value is 10 for the full-page loader and 9 to the others. This is to avoid other loaders in the page be in the top of the full-page loader. But I really don't like these magic numbers.

In your particular case you do want the loader to be in the top of the bootstrap dialog, but what if another person don't? I can think in some scenarios that would be interesting to have the loader between the page and the dialog, for example, that's why I can't just assign a gigantic value to it.

One possible fix I could implement to make the z-index assignment better would be also detecting the z-index of the target and apply this value +1. Doing that would always guarantee the overlay to be in the top of the target and I think it would solve your problem, wouldn't it? What do you think?

About the rounded corners: I agree, the detector would be interesting. And this also gave me the idea to the z-index detection, thanks!

from jquery-loading.

mikestu avatar mikestu commented on September 27, 2024

Thanks for the response! Yes, I do like your idea on using the target like that for the z-index as well. I'll keep an eye out to see if you get a chance to add those in. If I end up having time to help, I may take a stab at it.

from jquery-loading.

CarlosBonetti avatar CarlosBonetti commented on September 27, 2024

The z-index is now set to the target z-index +1.

The rounded corners can be achieved by providing a custom overlay or a custom theme to the plugin.

from jquery-loading.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.