GithubHelp home page GithubHelp logo

Comments (7)

caroso1222 avatar caroso1222 commented on July 30, 2024

Good catch, thanks for opening the issue. I didn't really have any plans of supporting IE (unpopular opinion, I know) but if this is the only pain point to make it work in IE then I'll look into it and fix it in the next patch. Thanks again for noting it!

from notyf.

mdix avatar mdix commented on July 30, 2024

Thanks. I'm glad to hear that and yes, it is the only thing that prevents notyf from working in IE11. After I polyfilled Array.prototype.findIndex everything worked as expected.

from notyf.

mdix avatar mdix commented on July 30, 2024

You can just put this in a file and use it, I guess.

from notyf.

terales avatar terales commented on July 30, 2024

@caroso1222 would you accept a PR on this?

I'll just implement the old way of finding an index instead of a modern "findIndex" method to make it usable without any polyfills.

from notyf.

caroso1222 avatar caroso1222 commented on July 30, 2024

Hey @terales. Sorry for the late reply, still coming back from holidays. Yeah definitely, thanks! Take a stab at it and I'll review the PR.

from notyf.

terales avatar terales commented on July 30, 2024

@mdix can you prepare a PR, please?

I'm on Ubuntu since January and it seems that I would be without available Windows machine for a while now.

from notyf.

caroso1222 avatar caroso1222 commented on July 30, 2024

Fixed it already. Thank you all for the help! 😃

from notyf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.