Extending default Eloquent implementations about sentinel

[suwardany]

Hey @paulofreitas

Check out the feature/updates branch.

It will be merged into master today.

Side Note: Groups have been renamed to roles already.

[paulofreitas]

Hey @suwardany, thanks for clarifying that! :)

I've updated my composer.json to use dev-feature/updates for cartalyst/sentinel. I'm still adapting changes, but it looks much nicer now! In the meantime I've already identified a small issue here, but I'll wait the merge to make a PR. 🍻

[suwardany]

Feel free to PR the feature branch, won't be much time left before a tag is released.

[brunogaspar]

Sentinel is tagged, if you have a PR to send, send to the 1.0 branch.

Thanks.

[paulofreitas]

Yeah, I just noticed it right now, thanks! :)

Let me understand one thing, since it's on topic yet... When I was using Sentry 3.0-dev, Auth::getUser() returned my custom user model I had defined on the package config file. Now it seems to be returning a Cartalyst\Sentinel\Users\EloquentUser instance despite having changed the user model on config, which was successfully migrated to the new Sentinel config file.

Am I missing something? Shouldn't Auth::getUser() return my user model instance in place of Sentinel's EloquentUser model? Cause actually it's breaking all the Auth::getUser()->customUserModelMethod() stuff I use... I'm almost sure I've changed everything that needed to change to migrate to Sentinel.

Thank you in advance!

[brunogaspar]

We'll have a look into it.

[paulofreitas]

I'm still trying to better identify where the issue happens, and I think I get some progress here: sometimes Auth::getUser() correctly returns my custom user model, sometimes it returns a Cartalyst\Sentinel\Users\EloquentUser instance. It seems to happen only on subsequent requests after a successful authentication, thus I think it's related with the new persistence stuff. I'll update here if I get any further details on that. Thanks for all the effort! :)

[suwardany]

Thanks for the update @paulofreitas .. I'll have a look into it as well today.

[paulofreitas]

Thank YOU for fixing the issue so quickly! I can confirm that all the related issues are gone with that fix, it's all working now! 😃 👍