Sample release version doesn't work about carter

[jchannon]

@raminmjj @richardprice can you pull the branch in the linked PR and run the sample or your own application to see if it works now. thanks

[jchannon]

If routing isn't working why is it logging We hit a route! ?

[jchannon]

Oh it's returning 404. Hmm

[JoeStead]

Can reproduce on MacOS too with:

dotnet publish -c Release

It's fine when published with Debug though. This should be a fun one

[jchannon]

I'm guessing assembly scanning

…

On 24 January 2018 at 11:32, Joe Stead ***@***.***> wrote: Can reproduce on MacOS too with: dotnet publish -c Release It's fine when published with Debug though. This should be a fun one — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGapiLDAhRSxOkiAuESHUb9h9G7u_d-ks5tNxTDgaJpZM4RrGja> .

[JoeStead]

Yeah, but the AfterHook is writing out "We hit a route" to stdout. If it was assembly scanning I'd expect that to fail too.

[JoeStead]

Ahh nevermind, that afterhook is misleading. It's hit even when no route is resolved :)

[JoeStead]

So for some reason, when built against a release configuration, this line:

https://github.com/JoeStead/Botwin/blob/26711fb626607bf16b675fd8d3ad7194a569ac06/src/BotwinExtensions.cs#L153

returns Microsoft.AspNetCore.Hosting, Version=2.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60 as an assembly - obviously we're not going to find any modules in there.

When built against the debug configuration, we correctly return BotwinSample, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null allowing the modules to be resolved.

[jchannon]

Thought that might be the case. Hmm

…

On 24 January 2018 at 11:42, Joe Stead ***@***.***> wrote: So for some reason, when built against a release configuration, this line: https://github.com/JoeStead/Botwin/blob/26711fb626607bf16b675fd8d3ad71 94a569ac06/src/BotwinExtensions.cs#L153 returns Microsoft.AspNetCore.Hosting, Version=2.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60 as an assembly - obviously we're not going to find any modules in there. When built against the debug configuration, we correctly return BotwinSample, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null allowing the modules to be resolved. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGapu1VwyVgUAwkK58Ipp12grxvuYZRks5tNxcQgaJpZM4RrGja> .

[JoeStead]

As a workaround, when adding the Botwin services, you can tell it what assemblies to scan:
services.AddBotwin(Assembly.GetAssembly(typeof(Startup)));

It's sort of nasty, but will allow you to publish to release mode correctly until we can come up with a way of doing it properly

[jchannon]

I changed it because of unit tests *I think* https://github.com/jchannon/Botwin/pull/72/files#diff-82112b99eae34877f111696bbe53aa64R153 Going to have to find out the best of way of doing this I think

…

On 24 January 2018 at 11:58, Joe Stead ***@***.***> wrote: As a workaround, when adding the Botwin services, you can tell it what assemblies to scan: services.AddBotwin(Assembly.GetAssembly(typeof(Startup))); It's sort of nasty, but will allow you to publish to release mode correctly until we can come up with a way of doing it properly — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGapqexHSNn6obJljy0khTBJCQkFyirks5tNxrRgaJpZM4RrGja> .

[JoeStead]

I tried I a few variants of Assembly.Get and all of them failed with similar problems

[jchannon]

@davidfowl @poke any ideas

[raminmjj]

@jchannon thank you.
your PR worked.