frescobaldi build fails due to poppler-qt4 no longer existing about homebrew-qt4

[albertosottile]

Are you still interested in a PR for this? I just tested it locally, everything works besides homebrew/lilypond that has been deprecated and moved to a cask (the user can still install it manually if needed).

[cartr]

I'd definitely still be interested in a PR for this if you've gotten it working.

…

On Fri, Jul 20, 2018, 6:43 AM Alberto Sottile ***@***.***> wrote: Are you still interested in a PR for this? I just tested it locally, everything works besides homebrew/lilypond that has been deprecated and moved to a cask (the user can still install it manually if needed). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE_71Zh_r-S9lXCjWm3CRQnUZZpCVM5Lks5uIbRhgaJpZM4M2DbB> .

[albertosottile]

That's great, I have a question though: at this moment I had to create poppler formula using the same name as in homebrew-core because the poppler path is hardcoded somewhere in the frescobaldi building code. If that is ok for you, I can quickly prepare the PR. Otherwise, I'll change the name to something like poppler-qt4 and try to fix it in the frescobaldi formula or with a patch.

[cartr]

It'd probably be better to use a new name, like poppler-qt4, so people could install it and homebrew-core's Poppler side-by-side if they wanted to.

…

On Sat, Jul 21, 2018, 5:08 PM Alberto Sottile ***@***.***> wrote: That's great, I have a question though: at this moment I had to create poppler formula using the same name as in homebrew-core because the poppler path is hardcoded somewhere in the frescobaldi building code. If that is ok for you, I can quickly prepare the PR. Otherwise, I'll change the name to something like poppler-qt4 and try to fix it in the frescobaldi formula or with a patch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE_71abGg6xTidaCIxFO1plxw6_i6bjDks5uI5g7gaJpZM4M2DbB> .

[albertosottile]

Ok, working on it.
EDIT: Nevermind, it works. Opening the PR now.

[cartr]

Fixed by #61.