Comments (7)
@praveenrewar: Thanks for making those changes! I've merged the PR and released a new version of the action, so I'll close this issue now.
from setup-action.
Hi @praveenrewar! Thanks for the issue. I created a draft PR here: #203.
I notice that the format of the checksums in the release notes for kctrl
is a little different from the other Carvel repos. They all provide the output of md5sum
(which always has two spaces between the hash and the filename) and prefix the binary name with the relative path signifier ./
. For example:
5fd3afbe09a66fc9e91252c57448045eeeab1ee3f6d305da6f9885186b744e67 ./kbld-darwin-amd64
2962cd78c6c45cf3f03ca76c52ca7517ed5f2ceba6ed1b3d594a16d516ef05a2 ./kbld-darwin-arm64
67c86ece94a3747b2e011a5b72044b69f2594ca807621b1e1e4c805f6abcaeef ./kbld-linux-amd64
658725c5dab5349dd4cb826ff9278749f093ed2275aadf51dc994265e6599b2c ./kbld-linux-arm64
9dcb4d6db2901257f8f23059c13b41d37ef8b8b36f27d909cceb81934fc9e862 ./kbld-windows-amd64.exe
04c51f4aa92d117d22513727ee37cda1b5ae18bf94a223093f11727d0ba878b4 ./kbld-windows-arm64.exe
However, per the failing tests in the PR, the release notes for kctrl
are sometimes in a different format (with variations in the number of spaces between the hash and the binary, and not all binaries prefixed with the relative path signifier). This results in failures like this:
Unable to verify checksum for kctrl-linux-amd64. Expected to find "4442f03491aca0299adad3b44061930dccf57eea47cc8289319cb1fc4d9b4029 ./kctrl-linux-amd64" in release notes.
Would you be up for amending the release notes for kctrl
to match the format of other Carvel repos? There's something to be said for consistency, and I would prefer to avoid adding regexes or conditionals to the security check if possible, as that introduces a new bug surface area.
from setup-action.
Thank you so much for the quick turn around @jbrunton. Sure, I will add the ./
with the filenames in the release notes.
from setup-action.
Hi @jbrunton! We are planning to make a kapp-controller release next week (which will have the release notes in the correct format), is it okay to merge the PR after that?
We are okay with supporting kctrl from the next release in the Github action (just trying to avoid updating the release notes as much as possible)
from setup-action.
@praveenrewar: sure thing! Let me know once that's released and then I can re-run the tests in the PR to check everything works as expected.
from setup-action.
Awesome! Sure, I will let you know :)
from setup-action.
Hi @jbrunton! kapp-controller v0.38.4 is released and the tests on the PR seem to be passing now (after I re-triggered them)
The release workflow is also updated to have the checksums in a consistent format.
from setup-action.
Related Issues (9)
- Pursue getting this action certified by GitHub HOT 3
- GH is deprecating Node.js 12 actions. Upgrade to Node >= 16 needed
- vmware-tanzu/carvel-setup-action@v1 disappeared HOT 8
- Cannot install ytt HOT 2
- Replace set-env commands in release workflow with environment files HOT 2
- Migrate to vmware-tanzu HOT 3
- checksum of ytt is not working since 0.31.0 HOT 5
- Exclude as Opposed to Only Approach for Which Carvel Tools to Install HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from setup-action.